fix(dashboard): Remove bar at bottom of dashboard edit sidebar

[codyml]

SUMMARY

This PR removes a bar that was appearing at the bottom of the dashboard edit sidebar. It does some misc cleanup along the way:

• Removes builder-sidepane.less, which contains a few actively-used styles but is mostly unused styles, and moves the actively-used styles into the relevant component files
• Replaces use of react-sticky with CSS position: sticky (which seems to now be supported for all of the browsers we're targeting) for the sidebar
• Removes various styles and props that are now unnecessary because of above changes

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

• Check that the bar is gone
• Check that the Edit sidebar otherwise looks identical
• Check that the Edit sidebar looks identical in standalone mode (add standalone=1 to the end of the query string)

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21807 (16555ff) into master (779d9f7) will decrease coverage by 0.00%.
The diff coverage is 66.66%.

@@            Coverage Diff             @@
##           master   #21807      +/-   ##
==========================================
- Coverage   66.95%   66.95%   -0.01%     
==========================================
  Files        1807     1807              
  Lines       69196    69186      -10     
  Branches     7402     7399       -3     
==========================================
- Hits        46331    46322       -9     
- Misses      20954    20955       +1     
+ Partials     1911     1909       -2     

Flag	Coverage Δ
javascript	53.37% <66.66%> (-0.02%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...t-frontend/src/dashboard/components/SliceAdder.jsx	60.27% <50.00%> (-2.40%)	⬇️
...ashboard/components/BuilderComponentPane/index.tsx	66.66% <66.66%> (-9.81%)	⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx	75.24% <100.00%> (ø)
superset-frontend/src/SqlLab/actions/sqlLab.js	62.85% <0.00%> (-0.20%)	⬇️
...erset-frontend/src/components/Chart/chartAction.js	56.77% <0.00%> (ø)
...et-ui-core/src/connection/callApi/parseResponse.ts	100.00% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[stephenLYZ]

/testenv up

[github-actions]

@stephenLYZ Ephemeral environment spinning up at http://35.91.193.56:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[stephenLYZ]

Awesome work! I have found some issues:

1. It looks like layout elements tab has incorrect width:

master	current

2. The shadows on the left do not behave the same as the current master, is this as expected?

master	current

3. It is wired that tab shakes when searching

current:

2022-10-15.11.15.47.mov

master:

2022-10-15.11.17.35.mov

[codyml]

Awesome work! I have found some issues:

@stephenLYZ Oh jeez sorry, those first two were things I thought I fixed and had no idea about the last one – should have double-checked before pushing. Will fix those ASAP.

[stephenLYZ]

/testenv up

[github-actions]

@stephenLYZ Ephemeral environment spinning up at http://34.213.209.72:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[stephenLYZ]

It seems weird that the entire page shakes when searching charts. Maybe cause by re-rendering:

2022-10-21.6.48.31.mov

[codyml]

It seems weird that the entire page shakes when searching charts. Maybe cause by re-rendering:

@stephenLYZ Yikes that is strange, thanks for catching. Will see if I can fix.

[codyml]

@stephenLYZ Was finally able to reproduce by making my screen very very large! I couldn't figure out exactly what was causing it but I narrowed it down to something about the ParentSize helper component triggering refreshes. I replaced it with an AutoSizer component that was already part of the react-virtualized library – does it look better on your end?

Before:

Before.mov

After:

After.mov

[stephenLYZ]

/testenv up

[github-actions]

@stephenLYZ Ephemeral environment spinning up at http://18.236.139.253:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[stephenLYZ]

LGTM! Thanks for this!

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.