-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Convert direct use of antd Icons to use 'Icons' component #21823
Conversation
Change how tests access elements due to reference change
@agl-developer please fix CI. I will run an ephemeral env here. Also, it is important that you provide screenshots of before and after. These icons can cause subtle changes in positions and colors which would be hard to notice without a prior reference. |
Codecov Report
@@ Coverage Diff @@
## master #21823 +/- ##
==========================================
+ Coverage 66.95% 66.96% +0.01%
==========================================
Files 1807 1808 +1
Lines 69196 69247 +51
Branches 7402 7410 +8
==========================================
+ Hits 46331 46373 +42
- Misses 20954 20964 +10
+ Partials 1911 1910 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Could a committer close this PR in favor of #22516? |
SUMMARY
Convert direct use of antd Icons to use 'Icons' component
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
LabeledErrorBountInput Before
LabeledErrorBountInput After
Chart dropdown and select Before
Chart dropdown and select After
Chart Export
Dashboard Filter
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION