Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Convert direct use of antd Icons to use 'Icons' component #21823

Closed
wants to merge 11 commits into from

Conversation

agl-developer
Copy link
Contributor

@agl-developer agl-developer commented Oct 16, 2022

SUMMARY

Convert direct use of antd Icons to use 'Icons' component

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

LabeledErrorBountInput Before
LabeledErrorBoundInput before

LabeledErrorBountInput After
LabeledErrorBoundInput after

Chart dropdown and select Before
Chart dropdown and select before

Chart dropdown and select After
Chart dropdown and select after

Chart Export
Chart Export

Dashboard Filter
Dashboard filter

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Herbert Gainor added 3 commits October 16, 2022 20:17
@geido
Copy link
Member

geido commented Oct 20, 2022

@agl-developer please fix CI. I will run an ephemeral env here.

Also, it is important that you provide screenshots of before and after. These icons can cause subtle changes in positions and colors which would be hard to notice without a prior reference.

@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #21823 (9da6f0e) into master (779d9f7) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #21823      +/-   ##
==========================================
+ Coverage   66.95%   66.96%   +0.01%     
==========================================
  Files        1807     1808       +1     
  Lines       69196    69247      +51     
  Branches     7402     7410       +8     
==========================================
+ Hits        46331    46373      +42     
- Misses      20954    20964      +10     
+ Partials     1911     1910       -1     
Flag Coverage Δ
javascript 53.42% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...mponents/useExploreAdditionalActionsMenu/index.jsx 63.41% <ø> (ø)
...aseModal/DatabaseConnectionForm/EncryptedField.tsx 10.00% <ø> (ø)
...abaseModal/DatabaseConnectionForm/TableCatalog.tsx 10.00% <ø> (ø)
...end/src/components/Form/LabeledErrorBoundInput.tsx 95.45% <100.00%> (+0.45%) ⬆️
superset-frontend/src/components/Select/utils.tsx 81.81% <100.00%> (+0.33%) ⬆️
...ard/components/FiltersBadge/DetailsPanel/index.tsx 83.33% <100.00%> (+1.51%) ⬆️
.../components/FiltersBadge/FilterIndicator/index.tsx 88.88% <100.00%> (+1.38%) ⬆️
...nativeFilters/FilterBar/FilterSets/EditSection.tsx 76.66% <100.00%> (+0.80%) ⬆️
...tiveFilters/FilterBar/FilterSets/FilterSetUnit.tsx 93.75% <100.00%> (+0.89%) ⬆️
...ashboard/components/BuilderComponentPane/index.tsx 66.66% <0.00%> (-9.81%) ⬇️
... and 44 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@codyml
Copy link
Member

codyml commented Dec 22, 2022

Could a committer close this PR in favor of #22516?

@rusackas rusackas closed this Jan 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants