Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(select filter): add CRLF separator for Windows #21867

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

mapledan
Copy link
Contributor

SUMMARY

The token separators without the CRLF.
In Windows environment, when copy the multiple line text and paste to Select Filters, there is the carriage return behind the result value.
The query filter contain "\r", affecting the query result is incorrect.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Environment: Windows OS

  1. Copy the multiple line text.
  2. Paste to the Select Filter.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

Merging #21867 (894e4f3) into master (b773354) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21867   +/-   ##
=======================================
  Coverage   66.92%   66.92%           
=======================================
  Files        1805     1805           
  Lines       69074    69074           
  Branches     7378     7378           
=======================================
  Hits        46228    46228           
  Misses      20940    20940           
  Partials     1906     1906           
Flag Coverage Δ
javascript 53.32% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...perset-frontend/src/components/Select/constants.ts 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the improvement!

@michael-s-molina michael-s-molina merged commit 7c4102c into apache:master Oct 19, 2022
@mapledan mapledan deleted the patch-1 branch October 19, 2022 11:58
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants