Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bump gecko and mozilla in Dockerfile #21995

Merged
merged 1 commit into from
Nov 1, 2022
Merged

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Nov 1, 2022

SUMMARY

This bumps geckodriver and mozilla in the docker file, which helps with some marionette issues that users have had.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #21995 (a6e3e4c) into master (72598a5) will increase coverage by 1.26%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21995      +/-   ##
==========================================
+ Coverage   65.72%   66.99%   +1.26%     
==========================================
  Files        1809     1809              
  Lines       69335    69335              
  Branches     7413     7413              
==========================================
+ Hits        45571    46448     +877     
+ Misses      21853    20976     -877     
  Partials     1911     1911              
Flag Coverage Δ
hive 52.90% <ø> (ø)
mysql 78.36% <ø> (ø)
postgres 78.42% <ø> (ø)
presto 52.80% <ø> (ø)
python 81.52% <ø> (+2.61%) ⬆️
sqlite 76.90% <ø> (ø)
unit 51.15% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/connectors/sqla/models.py 91.01% <0.00%> (+0.17%) ⬆️
superset/databases/api.py 93.53% <0.00%> (+0.30%) ⬆️
superset/sql_lab.py 82.12% <0.00%> (+0.38%) ⬆️
superset/views/base_api.py 98.44% <0.00%> (+0.38%) ⬆️
superset/db_engine_specs/presto.py 87.78% <0.00%> (+0.40%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/datasets/schemas.py 97.40% <0.00%> (+1.29%) ⬆️
superset/commands/exceptions.py 93.84% <0.00%> (+1.53%) ⬆️
superset/initialization/__init__.py 91.00% <0.00%> (+2.00%) ⬆️
superset/explore/commands/get.py 88.77% <0.00%> (+2.04%) ⬆️
... and 49 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AAfghahi AAfghahi merged commit 25be9ab into master Nov 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the arash/marionetteIssue branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants