Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboard): chart doesn't resize when tab switch #22009

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

Currently the chart doesn't resize when tab switch.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

You can see the charts have been cut off:

2022-11-03.12.52.14.mov

after

2022-11-03.12.41.12.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue: Chart width not refreshed properly while tab switch #21852
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 2, 2022

Codecov Report

Merging #22009 (02f91f8) into master (bf00193) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22009      +/-   ##
==========================================
- Coverage   66.95%   66.95%   -0.01%     
==========================================
  Files        1807     1813       +6     
  Lines       69231    69427     +196     
  Branches     7406     7479      +73     
==========================================
+ Hits        46357    46484     +127     
- Misses      20966    21013      +47     
- Partials     1908     1930      +22     
Flag Coverage Δ
javascript 53.46% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../src/dashboard/components/gridComponents/Chart.jsx 53.98% <ø> (ø)
superset-frontend/src/components/Select/styles.tsx 81.81% <0.00%> (-18.19%) ⬇️
...t-ui-chart-controls/src/shared-controls/mixins.tsx 16.66% <0.00%> (-16.67%) ⬇️
...perset-ui-chart-controls/src/sections/sections.tsx 71.42% <0.00%> (-16.08%) ⬇️
...l/AdhocFilterEditPopoverSimpleTabContent/index.tsx 62.73% <0.00%> (-6.29%) ⬇️
superset-frontend/src/utils/downloadAsImage.ts 11.11% <0.00%> (-4.68%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 95.45% <0.00%> (-4.55%) ⬇️
...ontrols/DndColumnSelectControl/DndFilterSelect.tsx 42.60% <0.00%> (-1.43%) ⬇️
...et-frontend/src/components/TableSelector/index.tsx 77.63% <0.00%> (-1.04%) ⬇️
...eFilters/FiltersConfigModal/FiltersConfigModal.tsx 63.63% <0.00%> (-0.80%) ⬇️
... and 39 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. @geido @jinghua-qa Can you review the PR so we can merge it?

@michael-s-molina michael-s-molina merged commit 309c064 into apache:master Dec 1, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants