chore(dataset): enable reload for schema and table #22032
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
long history but schema and table selector isn't enabled the reload feature when Dataset creation modal implemented.
Due to the cached dataset, user cannot create a new dataset using "Add dataset" modal when a new table recently added. In order to do so, user must hit the refresh request on sqllab page and then reload the modal again.
This commit enables the refresh button for formMode (which is only used on DatasetModal) in order to reduce the UX inconvenience.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
@ktmud @etr2460 cc: @john-bodley