Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dataset): enable reload for schema and table #22032

Conversation

justinpark
Copy link
Member

SUMMARY

long history but schema and table selector isn't enabled the reload feature when Dataset creation modal implemented.

Due to the cached dataset, user cannot create a new dataset using "Add dataset" modal when a new table recently added. In order to do so, user must hit the refresh request on sqllab page and then reload the modal again.

This commit enables the refresh button for formMode (which is only used on DatasetModal) in order to reduce the UX inconvenience.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screen Shot 2022-11-03 at 3 28 48 PM

After:
Screen Shot 2022-11-03 at 3 35 11 PM

TESTING INSTRUCTIONS

  • create a new table
  • go to datasets
  • click add new dataset
  • search the table just created

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@ktmud @etr2460 cc: @john-bodley

@codecov
Copy link

codecov bot commented Nov 3, 2022

Codecov Report

Merging #22032 (ea5d4ac) into master (68e8b00) will decrease coverage by 0.04%.
The diff coverage is 100.00%.

❗ Current head ea5d4ac differs from pull request most recent head 72096f4. Consider uploading reports for the commit 72096f4 to get more accurate results

@@            Coverage Diff             @@
##           master   #22032      +/-   ##
==========================================
- Coverage   67.03%   66.99%   -0.05%     
==========================================
  Files        1813     1815       +2     
  Lines       69425    69522      +97     
  Branches     7448     7479      +31     
==========================================
+ Hits        46542    46579      +37     
- Misses      20963    21013      +50     
- Partials     1920     1930      +10     
Flag Coverage Δ
javascript 53.46% <100.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx 92.53% <100.00%> (ø)
...et-frontend/src/components/TableSelector/index.tsx 77.63% <100.00%> (ø)
superset-frontend/src/components/Select/styles.tsx 81.81% <0.00%> (-18.19%) ⬇️
superset-frontend/src/dashboard/actions/hydrate.js 1.78% <0.00%> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <0.00%> (ø)
...ilters/FilterBar/FilterBarLocationSelect/index.tsx 92.85% <0.00%> (ø)
...rontend/src/components/DropdownContainer/index.tsx 0.00% <0.00%> (ø)
...set-frontend/src/components/Select/AsyncSelect.tsx 87.84% <0.00%> (+0.13%) ⬆️
superset-frontend/src/components/Select/Select.tsx 92.70% <0.00%> (+0.15%) ⬆️
...omponents/nativeFilters/FilterBar/Header/index.tsx 95.45% <0.00%> (+4.15%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ktmud ktmud merged commit 5e1eecb into apache:master Nov 4, 2022
justinpark added a commit to airbnb/superset-fork that referenced this pull request Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants