Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add risingwave.py in db engine specs #22123

Merged
merged 3 commits into from
Nov 30, 2022

Conversation

BowenXiao1999
Copy link
Contributor

@BowenXiao1999 BowenXiao1999 commented Nov 15, 2022

SUMMARY

Fixes #22122

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Can see the time grain option now.
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

@codecov
Copy link

codecov bot commented Nov 15, 2022

Codecov Report

Merging #22123 (cbe1b75) into master (969c963) will increase coverage by 0.22%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #22123      +/-   ##
==========================================
+ Coverage   66.74%   66.96%   +0.22%     
==========================================
  Files        1841     1834       -7     
  Lines       70220    69896     -324     
  Branches     7672     7570     -102     
==========================================
- Hits        46865    46805      -60     
+ Misses      21371    21133     -238     
+ Partials     1984     1958      -26     
Flag Coverage Δ
hive 52.57% <100.00%> (?)
mysql 78.07% <100.00%> (+<0.01%) ⬆️
postgres 78.14% <100.00%> (+<0.01%) ⬆️
presto 52.46% <100.00%> (+<0.01%) ⬆️
python 81.34% <100.00%> (+0.20%) ⬆️
sqlite 76.60% <100.00%> (+<0.01%) ⬆️
unit 50.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engine_specs/risingwave.py 100.00% <100.00%> (ø)
...hboard/components/nativeFilters/FilterBar/utils.ts 53.84% <0.00%> (-6.16%) ⬇️
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 31.25% <0.00%> (-4.47%) ⬇️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 50.74% <0.00%> (-1.31%) ⬇️
...c/SqlLab/components/TemplateParamsEditor/index.tsx 82.35% <0.00%> (-0.99%) ⬇️
superset-frontend/src/SqlLab/actions/sqlLab.js 62.69% <0.00%> (-0.78%) ⬇️
...BigNumber/BigNumberWithTrendline/transformProps.ts 47.05% <0.00%> (-0.77%) ⬇️
...plugin-chart-echarts/src/BoxPlot/transformProps.ts 54.23% <0.00%> (-0.77%) ⬇️
...plugin-chart-echarts/src/Treemap/transformProps.ts 51.51% <0.00%> (-0.73%) ⬇️
...d/src/SqlLab/components/ShareSqlLabQuery/index.tsx 80.76% <0.00%> (-0.72%) ⬇️
... and 97 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro
Copy link
Member

villebro commented Nov 17, 2022

Hi @BowenXiao1999 , thanks for the contribution and always happy to see more databases added to Superset! A few comments:

  • would it be possible to add documentation for how to connect to RisingWave here: https://github.com/apache/superset/tree/master/docs/docs/databases ?
  • Based on your screenshot, you've selected monthly time grain, but still the table is displaying two values for January 2022 (there should only be one entry for that month). Is time grain working correctly?

@BowenXiao1999
Copy link
Contributor Author

Hi @BowenXiao1999 , thanks for the contribution and always happy to see more databases added to Superset! A few comments:

  • would it be possible to add documentation for how to connect to RisingWave here: https://github.com/apache/superset/tree/master/docs/docs/databases ?
  • Based on your screenshot, you've selected monthly time grain, but still the table is displaying two values for January 2022 (there should only be one entry for that month). Is time grain working correctly?

Thanks! I will provide more context based on your suggestion.

@BowenXiao1999
Copy link
Contributor Author

The reason that these entry is not merged is expected I think, cuz the raw records is chosen and no group by or agg is done on.
image

After switch to aggregation, they are correctly differetiate.
image

BTW, we have a demo link: https://risingwave-labs.notion.site/Tutorial-Building-streaming-dashboards-with-Superset-ae1c667aa6734bffa38f0d260734a470, but maybe we should not put it in doc seems it evolve fast.

@villebro PTAL again and feel free to give comments, thanks!

@villebro
Copy link
Member

The reason that these entry is not merged is expected I think, cuz the raw records is chosen and no group by or agg is done on. image

After switch to aggregation, they are correctly differetiate. image

BTW, we have a demo link: https://risingwave-labs.notion.site/Tutorial-Building-streaming-dashboards-with-Superset-ae1c667aa6734bffa38f0d260734a470, but maybe we should not put it in doc seems it evolve fast.

@villebro PTAL again and feel free to give comments, thanks!

Ah, makes sense 👍 @BowenXiao1999 are you able to add a note to the docs as requested in my previous review? We want to make sure others will also know that RisingWave is also supported!

@pull-request-size pull-request-size bot added size/M and removed size/S labels Nov 30, 2022
@BowenXiao1999
Copy link
Contributor Author

The reason that these entry is not merged is expected I think, cuz the raw records is chosen and no group by or agg is done on. image
After switch to aggregation, they are correctly differetiate. image
BTW, we have a demo link: https://risingwave-labs.notion.site/Tutorial-Building-streaming-dashboards-with-Superset-ae1c667aa6734bffa38f0d260734a470, but maybe we should not put it in doc seems it evolve fast.
@villebro PTAL again and feel free to give comments, thanks!

Ah, makes sense 👍 @BowenXiao1999 are you able to add a note to the docs as requested in my previous review? We want to make sure others will also know that RisingWave is also supported!

Sorry my bad, forgot to push. Already added, pls check.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit e80e10e into apache:master Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat: add db_engine_specs/risingwave.py to support time grain
3 participants