Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build(deps): bump @ant-design/icons from 4.2.2 to 4.8.0 in /superset-frontend #22158

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 17, 2022

Bumps @ant-design/icons from 4.2.2 to 4.8.0.

Commits
Maintainer changes

This version was pushed to npm by madccc, a new releaser for @​ant-design/icons since your current version.


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [@ant-design/icons](https://github.com/ant-design/ant-design-icons) from 4.2.2 to 4.8.0.
- [Release notes](https://github.com/ant-design/ant-design-icons/releases)
- [Commits](https://github.com/ant-design/ant-design-icons/commits)

---
updated-dependencies:
- dependency-name: "@ant-design/icons"
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot added dependabot npm Dependabot - npm related PRs labels Nov 17, 2022
@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #22158 (35b74fb) into master (d352b74) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22158   +/-   ##
=======================================
  Coverage   66.99%   66.99%           
=======================================
  Files        1833     1833           
  Lines       69935    69935           
  Branches     7571     7571           
=======================================
  Hits        46855    46855           
  Misses      21121    21121           
  Partials     1959     1959           
Flag Coverage Δ
javascript 53.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

/testenv up

@rusackas
Copy link
Member

@michael-s-molina @geido @eric-briscoe Anyone feeling bold? This one makes me weirdly nervous, but I'm spinning up a test env to kick the tires on.

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://54.214.44.150:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@geido
Copy link
Member

geido commented Dec 16, 2022

@rusackas from a first look this seems ok. However, if we feel in danger we can run the visual regression suite before and after and see if anything weird appears there.

@rusackas
Copy link
Member

Let's just merge it... it seems like we can cleanly revert if needed, but honestly I'd rather start fixing-forward on cosmetic issues, and get up to speed on Ant versions.

@rusackas rusackas merged commit 0ca5e0e into master Dec 20, 2022
@dependabot dependabot bot deleted the dependabot/npm_and_yarn/superset-frontend/ant-design/icons-4.8.0 branch December 20, 2022 16:57
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels dependabot npm Dependabot - npm related PRs size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants