Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Adds time grain to Pivot Table v2 #22170

Merged
merged 2 commits into from
Nov 20, 2022
Merged

fix: Adds time grain to Pivot Table v2 #22170

merged 2 commits into from
Nov 20, 2022

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Nov 18, 2022 •
edited
Loading

SUMMARY

Fix a bug where the time grain was not being added to the Pivot Table v2.

Hat tip to @zhaoyongjie for helping with the issue!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-11-18.at.3.32.46.PM.mov
Screen.Recording.2022-11-18.at.3.31.59.PM.mov

TESTING INSTRUCTIONS

  • Create a Pivot Table v2 with a time dimension
  • Check that drilling to detail works when selecting a value from the time dimension

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina mentioned this pull request Nov 18, 2022
Closed
9 tasks
@michael-s-molina michael-s-molina merged commit 9a2cb43 into apache:master Nov 20, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyongjie zhaoyongjie zhaoyongjie approved these changes

@kgabryje kgabryje Awaiting requested review from kgabryje

@geido geido Awaiting requested review from geido

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@michael-s-molina @zhaoyongjie @mistercrunch