-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: don't stringify extraJson in form #22171
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22171 +/- ##
=======================================
Coverage 66.97% 66.98%
=======================================
Files 1832 1834 +2
Lines 69905 69952 +47
Branches 7570 7588 +18
=======================================
+ Hits 46820 46858 +38
- Misses 21127 21128 +1
- Partials 1958 1966 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
/testenv up |
@jinghua-qa Ephemeral environment spinning up at http://35.162.197.182:8080. Credentials are |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ephemeral environment shutdown and build artifacts deleted. |
(cherry picked from commit 78a4bd6)
🏷️ preset:2022.47 |
SUMMARY
This fixes a bug where the extra parameters field in the database connection modal was adding an extra layer of json encoding.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
typing and pasting into the extra engine parameters field should not encode the characters.
ADDITIONAL INFORMATION