Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't stringify extraJson in form #22171

Merged
merged 1 commit into from
Nov 21, 2022

Conversation

eschutho
Copy link
Member

SUMMARY

This fixes a bug where the extra parameters field in the database connection modal was adding an extra layer of json encoding.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
testrail_bq

After:
_DEV__Superset

TESTING INSTRUCTIONS

typing and pasting into the extra engine parameters field should not encode the characters.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #22171 (9295d1d) into master (06f87e1) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22171   +/-   ##
=======================================
  Coverage   66.97%   66.98%           
=======================================
  Files        1832     1834    +2     
  Lines       69905    69952   +47     
  Branches     7570     7588   +18     
=======================================
+ Hits        46820    46858   +38     
- Misses      21127    21128    +1     
- Partials     1958     1966    +8     
Flag Coverage Δ
javascript 53.81% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../CRUD/data/database/DatabaseModal/ExtraOptions.tsx 75.00% <ø> (ø)
...tend/src/SqlLab/components/TabStatusIcon/index.tsx 80.00% <0.00%> (-20.00%) ⬇️
...board/components/nativeFilters/FilterBar/index.tsx 50.00% <0.00%> (-10.44%) ⬇️
...ts/nativeFilters/FilterBar/ActionButtons/index.tsx 78.57% <0.00%> (-8.93%) ⬇️
...et-frontend/src/components/TableView/TableView.tsx 82.45% <0.00%> (-1.86%) ⬇️
...qlLab/components/EstimateQueryCostButton/index.tsx 61.90% <0.00%> (-1.74%) ⬇️
...frontend/src/components/DatabaseSelector/index.tsx 91.17% <0.00%> (-1.37%) ⬇️
...omponents/nativeFilters/FilterBar/Header/index.tsx 95.23% <0.00%> (-0.22%) ⬇️
...d/components/DashboardBuilder/DashboardBuilder.tsx 75.23% <0.00%> (-0.01%) ⬇️
superset-frontend/src/SqlLab/fixtures.ts 100.00% <0.00%> (ø)
... and 17 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jinghua-qa
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@jinghua-qa Ephemeral environment spinning up at http://35.162.197.182:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@jinghua-qa jinghua-qa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@Antonio-RiveroMartnez Antonio-RiveroMartnez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@eric-briscoe eric-briscoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eschutho eschutho merged commit 78a4bd6 into apache:master Nov 21, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Nov 22, 2022
@sadpandajoe
Copy link
Member

🏷️ preset:2022.47

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants