Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(dashboard): Fix missing React key errors #22266

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

codyml
Copy link
Member

@codyml codyml commented Nov 29, 2022

SUMMARY

A few components in native filters were throwing missing React key console errors. This PR adds keys to the array elements in question for those components.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Errors that should no longer appear:
Screen Shot 2022-11-29 at 2 34 09 PM
Screen Shot 2022-11-29 at 2 34 32 PM
Screen Shot 2022-11-29 at 2 34 55 PM

TESTING INSTRUCTIONS

Test out the horizontal and vertical filter bars, hovering over a filter to reveal the filter card, and check that the above key errors no longer appear.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags: HORIZONTAL_FILTER_BAR
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 29, 2022

Codecov Report

Merging #22266 (c35a4d9) into master (fb3e717) will increase coverage by 1.29%.
The diff coverage is 80.00%.

❗ Current head c35a4d9 differs from pull request most recent head 25b898d. Consider uploading reports for the commit 25b898d to get more accurate results

@@            Coverage Diff             @@
##           master   #22266      +/-   ##
==========================================
+ Coverage   65.54%   66.84%   +1.29%     
==========================================
  Files        1841     1841              
  Lines       70220    70221       +1     
  Branches     7670     7670              
==========================================
+ Hits        46027    46937     +910     
+ Misses      22211    21302     -909     
  Partials     1982     1982              
Flag Coverage Δ
javascript 53.66% <80.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ages/superset-ui-core/src/query/types/Dashboard.ts 100.00% <ø> (ø)
...ilters/FilterBar/FilterControls/FilterControls.tsx 72.34% <66.66%> (ø)
...d/components/nativeFilters/FilterCard/ScopeRow.tsx 63.15% <100.00%> (+2.04%) ⬆️
superset/databases/api.py 93.53% <0.00%> (+0.30%) ⬆️
superset/sql_lab.py 82.12% <0.00%> (+0.38%) ⬆️
superset/views/base_api.py 98.44% <0.00%> (+0.38%) ⬆️
superset/db_engine_specs/presto.py 88.22% <0.00%> (+0.41%) ⬆️
superset/db_engine_specs/__init__.py 85.71% <0.00%> (+1.19%) ⬆️
superset/datasets/schemas.py 97.40% <0.00%> (+1.29%) ⬆️
superset/commands/exceptions.py 93.84% <0.00%> (+1.53%) ⬆️
... and 55 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina merged commit 4657250 into apache:master Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants