Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alerts): cron picker alignment issues #22274

Merged

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Following the latest antd upgrade, the cron job picker in the alerts/report present some alignment issues in the selects.
This PR addresses those.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

old

After:

Screenshot 2022-11-30 at 10 54 38

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #22274 (2ccaef8) into master (969c963) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22274   +/-   ##
=======================================
  Coverage   66.74%   66.74%           
=======================================
  Files        1841     1841           
  Lines       70220    70219    -1     
  Branches     7672     7671    -1     
=======================================
  Hits        46865    46865           
  Misses      21371    21371           
+ Partials     1984     1983    -1     
Flag Coverage Δ
javascript 53.66% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/CronPicker/CronPicker.tsx 100.00% <ø> (ø)
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <0.00%> (ø)
...ges/superset-ui-core/src/query/buildQueryObject.ts 100.00% <0.00%> (ø)
...d/components/nativeFilters/FilterCard/ScopeRow.tsx 63.15% <0.00%> (+2.04%) ⬆️
...Filters/FilterBar/FilterControls/FilterDivider.tsx 84.00% <0.00%> (+2.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

rusackas commented Dec 2, 2022

Merging, but it might be nice to follow up and add a gridUnit or so of space between the line-wrapped Select components. Let me know if I should file an Issue.

Pasted_Image_12_2_22__2_19_PM

@rusackas rusackas merged commit 09bb1cc into apache:master Dec 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants