Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump clickhouse to 0.4.6 #22279

Merged
merged 1 commit into from
Nov 30, 2022

Conversation

betodealmeida
Copy link
Member

@betodealmeida betodealmeida commented Nov 30, 2022

SUMMARY

Bump clickhouse-connect to 0.4.6 so it works with SQLAlchemy 1.4.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

  1. Start ephemeral environment.
  2. Import this database: clickhouse_database.zip
  3. Run a test query.

ADDITIONAL INFORMATION

@betodealmeida betodealmeida changed the title Bump clickhouse 0.4.6 chore: bump clickhouse 0.4.6 Nov 30, 2022
@betodealmeida betodealmeida changed the title chore: bump clickhouse 0.4.6 chore: bump clickhouse to 0.4.6 Nov 30, 2022
@betodealmeida betodealmeida added the merge-if-green If approved and tests are green, please go ahead and merge it for me label Nov 30, 2022
@codecov
Copy link

codecov bot commented Nov 30, 2022

Codecov Report

Merging #22279 (72a0076) into master (2fd0a61) will decrease coverage by 1.46%.
The diff coverage is n/a.

❗ Current head 72a0076 differs from pull request most recent head 28dc858. Consider uploading reports for the commit 28dc858 to get more accurate results

@@            Coverage Diff             @@
##           master   #22279      +/-   ##
==========================================
- Coverage   66.82%   65.36%   -1.47%     
==========================================
  Files        1841     1841              
  Lines       70243    70243              
  Branches     7671     7671              
==========================================
- Hits        46942    45915    -1027     
- Misses      21318    22345    +1027     
  Partials     1983     1983              
Flag Coverage Δ
hive ?
mysql 78.04% <ø> (ø)
postgres 78.10% <ø> (ø)
presto ?
python 78.23% <ø> (-3.07%) ⬇️
sqlite 76.56% <ø> (ø)
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) ⬇️
superset/utils/pandas_postprocessing/resample.py 37.50% <0.00%> (-62.50%) ⬇️
superset/utils/pandas_postprocessing/select.py 38.46% <0.00%> (-61.54%) ⬇️
superset/utils/pandas_postprocessing/rename.py 40.00% <0.00%> (-60.00%) ⬇️
... and 57 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@betodealmeida betodealmeida merged commit 5de98c3 into apache:master Nov 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels merge-if-green If approved and tests are green, please go ahead and merge it for me size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants