Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing spacing in adhoc filters popover #22346

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Dec 6, 2022

SUMMARY

Fix missing margins around Select component in Adhoc Filter popover.

Missing semicolon resulted in a conditional expression adding a prefix undefined to styles added with css prop, which caused the margins in adhoc filters popover to not be displayed (in CSS, instead of margin-bottom: 16px; we had undefined margin-bottom: 16px;)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kgabryje kgabryje closed this Dec 6, 2022
@kgabryje kgabryje reopened this Dec 6, 2022
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #22346 (20d29c0) into master (e1ffdb9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22346   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1847     1847           
  Lines       70561    70561           
  Branches     7737     7737           
=======================================
  Hits        47174    47174           
  Misses      21380    21380           
  Partials     2007     2007           
Flag Coverage Δ
javascript 53.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Select/styles.tsx 82.60% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 3a4131f into apache:master Dec 7, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Dec 10, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants