fix(bigquery): Properly display errors for BigQuery DBs #22349
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR is fixing the wrong error messages we are seeing with BigQuery after we introduced these changes: #22024 .
Initially we were trying to get rid of
bigquery error:
section in the message, so we decided to split the exception message. However, the engine is NOT adding such section into the message, instead it's just returning:400 Syntax error: ...
for example, and it's us the ones adding that in this method:extract_error_message
from theBaseEngineSpec
class.So, these proposed changes are not splitting the message, just getting the first line (if multiple), and we keep the
bigquery error:
section in it. We could also override theextract_error_message
inBigQueryEngineSpec
to remove that section, however, I'd like to be consistent with all our other engines.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION