Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump holidays to 0.17.2 #22354

Merged
merged 1 commit into from
Dec 7, 2022
Merged

chore: Bump holidays to 0.17.2 #22354

merged 1 commit into from
Dec 7, 2022

Conversation

EugeneTorap
Copy link
Contributor

SUMMARY

Upgrade 'holidays' lib to 0.17.2 and use country_holidays function instead of deprecated CountryHoliday

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #22354 (f300445) into master (d1294a0) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #22354   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1847     1847           
  Lines       70560    70560           
  Branches     7737     7737           
=======================================
  Hits        47173    47173           
  Misses      21380    21380           
  Partials     2007     2007           
Flag Coverage Δ
hive 52.53% <50.00%> (ø)
mysql 77.95% <50.00%> (ø)
postgres 78.02% <50.00%> (ø)
presto 52.42% <50.00%> (ø)
python 81.23% <100.00%> (ø)
sqlite 76.48% <50.00%> (ø)
unit 50.92% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/date_parser.py 96.63% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit ff1d29c into apache:master Dec 7, 2022
@EugeneTorap EugeneTorap deleted the chore/bump-holidays branch December 7, 2022 08:18
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants