Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: adding additional code owners for cypress tests #22476

Merged
merged 1 commit into from
Dec 20, 2022

Conversation

rusackas
Copy link
Member

SUMMARY

Adding to the roster of code owners for the cypress codebase. We should have a chat about code owners in general and widen the net, but for now this should help unblock relevant PRs.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Dec 20, 2022

Codecov Report

Merging #22476 (e88cf4e) into master (858796b) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22476   +/-   ##
=======================================
  Coverage   66.90%   66.90%           
=======================================
  Files        1850     1850           
  Lines       70701    70701           
  Branches     7750     7750           
=======================================
  Hits        47306    47306           
  Misses      21379    21379           
  Partials     2016     2016           
Flag Coverage Δ
hive 52.46% <ø> (ø)
javascript 53.86% <ø> (ø)
mysql 77.96% <ø> (ø)
postgres 78.03% <ø> (ø)
presto 52.35% <ø> (ø)
python 81.24% <ø> (ø)
sqlite 76.50% <ø> (ø)
unit 50.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@eschutho eschutho merged commit c2a20e7 into master Dec 20, 2022
@rusackas rusackas deleted the change-cypress-codeowners branch December 20, 2022 23:01
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants