-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump Pillow to 9.3.0 #22489
chore: Bump Pillow to 9.3.0 #22489
Conversation
Codecov Report
@@ Coverage Diff @@
## master #22489 +/- ##
==========================================
- Coverage 66.90% 66.88% -0.02%
==========================================
Files 1851 1851
Lines 70696 70696
Branches 7764 7764
==========================================
- Hits 47299 47288 -11
- Misses 21375 21386 +11
Partials 2022 2022
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@EugeneTorap Is it possible it's related to this PR (cc: @villebro)? It looks like it changed some permissions for examples, and while CI shows up as green in GitHub when I click through to the Cypress run it looks like E2E failed with the same issues. |
@codyml thanks for investigating this. This seems to be quite the accumulation of problems.. I can work on fixing/improving those tests, but in the short term I think we should disable them, as they're testing something that's assumed to be incorrect behavior right now; the examples should not be created by the Admin user, otherwise the welcome page is incorrect. Also, it's weird that those tests were passing on CI if my PR broke them.. |
@villebro That all makes sense! I actually couldn't even tell that it was triggered by your PR when running locally at first because the Docker test setup names the admin user "Superset Admin" instead of "admin user" which caused a different fail 😪 skipping them for now sounds fine to me. No idea why the Cypress fail is showing up as green either! I think there are several tests that rely on database content that the tests themselves don't ensure is present before running – do you think at some point it would make sense to rewrite tests so they all input their own required content individually rather than relying on a pre-seeded database? Or at least do an audit to make sure that any mutations are reset at the end of the specs that do the mutations? On the other hand, I remember E2E catching issues for me that didn't break any tests directly but did mess with the database enough that it caused unrelated tests to fail, so making them more independent could decrease coverage... |
Hotfix to unblock master branch: #22512 |
SUMMARY
Fix #22235 to resolve next CVE:
upgrade Pillow to 9.3.0 to resolve GHSA-hr8g-f6r6-mr22, GHSA-m2vv-5vj5-2hm7, GHSA-q4mp-jvh2-76fj
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION