Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(chart): Added Papua New Guinea to countries map #22589

Merged
merged 2 commits into from
Jan 5, 2023
Merged

feat(chart): Added Papua New Guinea to countries map #22589

merged 2 commits into from
Jan 5, 2023

Conversation

wilfred-wulbou
Copy link
Contributor

@wilfred-wulbou wilfred-wulbou commented Jan 4, 2023

SUMMARY

Added Papua New Guinea to countries map chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

countries_map_chart

TESTING INSTRUCTIONS

Clone this fork. Open a terminal and cd to root directory, then execute the following:

cd superset-frontend && npm install
npm run plugins:storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding this!

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Merging #22589 (544c0eb) into master (40dba06) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #22589   +/-   ##
=======================================
  Coverage   67.00%   67.00%           
=======================================
  Files        1859     1859           
  Lines       71019    71019           
  Branches     7766     7766           
=======================================
  Hits        47587    47587           
  Misses      21410    21410           
  Partials     2022     2022           
Flag Coverage Δ
javascript 53.85% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit b352947 into apache:master Jan 5, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants