Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump sqloxide to 0.1.30 #22615

Merged
merged 2 commits into from
Jan 7, 2023
Merged

chore: bump sqloxide to 0.1.30 #22615

merged 2 commits into from
Jan 7, 2023

Conversation

nisheldo
Copy link
Contributor

@nisheldo nisheldo commented Jan 6, 2023

SUMMARY

updating sqloxide to 0.1.30 along with #22623 will allow arm based users to build superset locally

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 6, 2023

Codecov Report

Merging #22615 (edeb532) into master (3761694) will decrease coverage by 0.02%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #22615      +/-   ##
==========================================
- Coverage   67.01%   66.99%   -0.03%     
==========================================
  Files        1859     1859              
  Lines       71036    71036              
  Branches     7766     7766              
==========================================
- Hits        47608    47593      -15     
- Misses      21406    21421      +15     
  Partials     2022     2022              
Flag Coverage Δ
hive 52.47% <ø> (ø)
mysql ?
postgres 78.07% <ø> (-0.02%) ⬇️
presto 52.37% <ø> (ø)
python 81.30% <ø> (-0.05%) ⬇️
sqlite 76.46% <ø> (ø)
unit 51.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/utils/dataframe_utils.py 90.47% <0.00%> (-4.77%) ⬇️
superset/db_engine_specs/mysql.py 94.04% <0.00%> (-4.77%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/models/core.py 89.82% <0.00%> (-0.65%) ⬇️
superset/common/query_object.py 93.84% <0.00%> (-0.52%) ⬇️
superset/reports/commands/execute.py 91.66% <0.00%> (-0.34%) ⬇️
superset/views/core.py 74.75% <0.00%> (-0.23%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit 9cfbc22 into apache:master Jan 7, 2023
@nisheldo nisheldo deleted the bump-sqloxide branch January 8, 2023 00:02
@cwegener
Copy link
Contributor

cwegener commented Jan 9, 2023

Why was the compiled output file (requirements/development.txt) updated directly? What happened to pip-compile-multi?

# This file is autogenerated by pip-compile-multi
# To update, run:
#
#    pip-compile-multi
#

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants