Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(localization): localize legacy pivot table #22677

Merged
merged 1 commit into from
Apr 7, 2023

Conversation

artemonsh
Copy link
Contributor

@artemonsh artemonsh commented Jan 11, 2023

SUMMARY

Currently in the legacy "Pivot table" visualization word "All" is not localized as it comes from pandas.DataFrame.pivot_table. Since some people still use this visualization, I suggest localizing it.

BEFORE

image

AFTER

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #22677 (a7ada94) into master (73e53fa) will decrease coverage by 10.58%.
The diff coverage is n/a.

❗ Current head a7ada94 differs from pull request most recent head 211bb7d. Consider uploading reports for the commit 211bb7d to get more accurate results

@@             Coverage Diff             @@
##           master   #22677       +/-   ##
===========================================
- Coverage   67.10%   56.52%   -10.58%     
===========================================
  Files        1869     1871        +2     
  Lines       71580    71824      +244     
  Branches     7806     7765       -41     
===========================================
- Hits        48031    40597     -7434     
- Misses      21521    29207     +7686     
+ Partials     2028     2020        -8     
Flag Coverage Δ
hive 52.72% <ø> (+0.12%) ⬆️
mysql ?
postgres ?
presto 52.62% <ø> (+0.12%) ⬆️
python 59.19% <ø> (-22.13%) ⬇️
sqlite ?
unit 52.50% <ø> (+1.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...t-ui-chart-controls/src/operators/pivotOperator.ts 100.00% <ø> (ø)
...-ui-chart-controls/src/operators/renameOperator.ts 100.00% <ø> (ø)
...hart-controls/src/operators/timeCompareOperator.ts 100.00% <ø> (ø)
...controls/src/operators/timeComparePivotOperator.ts 100.00% <ø> (ø)
...rt-controls/src/operators/utils/isDerivedSeries.ts 100.00% <ø> (ø)
...t-controls/src/operators/utils/isTimeComparison.ts 100.00% <ø> (ø)
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)
...rset-ui-chart-controls/src/sections/chartTitle.tsx 100.00% <ø> (ø)
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <ø> (ø)
...onents/ColumnConfigControl/ColumnConfigControl.tsx 2.63% <ø> (+0.45%) ⬆️
... and 450 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@artemonsh artemonsh closed this Jan 17, 2023
@artemonsh artemonsh reopened this Jan 17, 2023
@artemonsh artemonsh closed this Feb 9, 2023
@artemonsh artemonsh reopened this Feb 9, 2023
@rusackas rusackas merged commit 749c4fd into apache:master Apr 7, 2023
@artemonsh artemonsh deleted the fix-legacy-pivot-localization branch April 8, 2023 02:32
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants