Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(logging): add health checks to statsd #22771

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

villebro
Copy link
Member

SUMMARY

  • Add StatsD logging to health checking endpoints
  • Consolidate all three methods into one

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jan 18, 2023

Codecov Report

Merging #22771 (b6c71b7) into master (577ac81) will decrease coverage by 1.44%.
The diff coverage is 100.00%.

❗ Current head b6c71b7 differs from pull request most recent head 513e35d. Consider uploading reports for the commit 513e35d to get more accurate results

@@            Coverage Diff             @@
##           master   #22771      +/-   ##
==========================================
- Coverage   67.30%   65.87%   -1.44%     
==========================================
  Files        1876     1876              
  Lines       71883    71880       -3     
  Branches     7867     7867              
==========================================
- Hits        48379    47348    -1031     
- Misses      21477    22505    +1028     
  Partials     2027     2027              
Flag Coverage Δ
hive ?
mysql 78.57% <100.00%> (-0.01%) ⬇️
postgres 78.64% <100.00%> (-0.01%) ⬇️
presto 52.49% <60.00%> (-0.01%) ⬇️
python 78.90% <100.00%> (-2.99%) ⬇️
sqlite 77.00% <100.00%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/health.py 100.00% <100.00%> (ø)
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
...set/advanced_data_type/plugins/internet_address.py 16.32% <0.00%> (-79.60%) ⬇️
superset/utils/pandas_postprocessing/boxplot.py 20.51% <0.00%> (-79.49%) ⬇️
superset/charts/post_processing.py 11.76% <0.00%> (-77.95%) ⬇️
...perset/advanced_data_type/plugins/internet_port.py 18.75% <0.00%> (-77.09%) ⬇️
superset/utils/pandas_postprocessing/rolling.py 21.87% <0.00%> (-68.75%) ⬇️
...perset/utils/pandas_postprocessing/contribution.py 34.61% <0.00%> (-65.39%) ⬇️
superset/utils/pandas_postprocessing/resample.py 37.50% <0.00%> (-62.50%) ⬇️
superset/utils/pandas_postprocessing/select.py 38.46% <0.00%> (-61.54%) ⬇️
... and 62 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro requested a review from dpgaspar January 18, 2023 19:24
@villebro villebro force-pushed the villebro/health-statsd branch from 52dd059 to 513e35d Compare January 19, 2023 12:54
@villebro villebro merged commit 13a186b into apache:master Jan 20, 2023
@villebro villebro deleted the villebro/health-statsd branch January 20, 2023 11:21
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants