Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(wrap-text): Wrap text support for specific columns in Grid #23328

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

SamraHanifCareem
Copy link
Contributor

SUMMARY

  • Wrapping text inside list view columns

BEFORE SCREENSHOTS OR ANIMATED GIF
BeforeWrap

AFTER SCREENSHOTS OR ANIMATED GIF
AfterWrap

TESTING INSTRUCTIONS

  • Route to any screen that contains list view. For instance, Saved Queries
  • Add columnsForWrapText={['col1 header','col2 header,...]}. in ListView as mentioned in the figure below:
    WrapUsage
  • Check for the wrapped text of the defined columns on the respective screen.

ADDITIONAL INFORMATION

  • Changes In List View: superset-frontend/src/components/ListView/ListView.tsx

@codecov
Copy link

codecov bot commented Mar 10, 2023

Codecov Report

Merging #23328 (962ab45) into master (57db8f9) will decrease coverage by 0.04%.
The diff coverage is 78.72%.

❗ Current head 962ab45 differs from pull request most recent head c8c96b8. Consider uploading reports for the commit c8c96b8 to get more accurate results

@@            Coverage Diff             @@
##           master   #23328      +/-   ##
==========================================
- Coverage   65.86%   65.82%   -0.04%     
==========================================
  Files        1909     1909              
  Lines       73491    73508      +17     
  Branches     7988     7988              
==========================================
- Hits        48404    48389      -15     
- Misses      23037    23069      +32     
  Partials     2050     2050              
Flag Coverage Δ
javascript 53.78% <ø> (ø)
mysql ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ListView/ListView.tsx 93.75% <ø> (ø)
superset/config.py 91.78% <ø> (ø)
superset/utils/webdriver.py 75.78% <47.36%> (-5.26%) ⬇️
superset/views/base.py 76.87% <100.00%> (+0.40%) ⬆️
superset/views/core.py 74.26% <100.00%> (-0.23%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.90.212.239:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@rusackas rusackas merged commit 4c257d2 into apache:master Apr 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Apr 6, 2023

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants