Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update default WEBDRIVER_OPTION_ARGS and add Firefox libs to Dockerfile #23388

Merged
merged 2 commits into from
Mar 17, 2023

Conversation

nytai
Copy link
Member

@nytai nytai commented Mar 16, 2023

SUMMARY

This default arg doesn't work with newer versions of the geckodriver. We should remove it so alerts/report/thumbnails work out of the box

Additionally, the upgrade on the firefox drivers broke the dev image's support of these features. This PR adds the missing libs required to make firefox work in the dev image.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 16, 2023

Codecov Report

Merging #23388 (20d8f9c) into master (da3791a) will increase coverage by 11.31%.
The diff coverage is 90.14%.

❗ Current head 20d8f9c differs from pull request most recent head 008cc68. Consider uploading reports for the commit 008cc68 to get more accurate results

@@             Coverage Diff             @@
##           master   #23388       +/-   ##
===========================================
+ Coverage   56.27%   67.58%   +11.31%     
===========================================
  Files        1907     1907               
  Lines       73495    73531       +36     
  Branches     7977     7981        +4     
===========================================
+ Hits        41356    49698     +8342     
+ Misses      30091    21785     -8306     
  Partials     2048     2048               
Flag Coverage Δ
hive 52.76% <26.66%> (?)
mysql 78.45% <100.00%> (?)
postgres 78.52% <100.00%> (?)
presto 52.68% <26.66%> (-0.02%) ⬇️
python 82.30% <100.00%> (+23.39%) ⬆️
sqlite 77.00% <100.00%> (?)
unit 52.48% <26.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 35.71% <ø> (ø)
...harts/src/Timeseries/Regular/Line/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 40.00% <ø> (ø)
...src/Timeseries/Regular/SmoothLine/controlPanel.tsx 40.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 33.33% <ø> (ø)
...s/plugin-chart-echarts/src/Timeseries/constants.ts 100.00% <ø> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 57.14% <0.00%> (-1.81%) ⬇️
...d/plugins/plugin-chart-echarts/src/utils/series.ts 87.05% <90.32%> (+1.68%) ⬆️
...tend/plugins/plugin-chart-echarts/src/constants.ts 100.00% <100.00%> (ø)
... and 8 more

... and 295 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@eschutho eschutho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! @nytai!

@nytai nytai changed the title fix: update default WEBDRIVER_OPTION_ARGS fix: update default WEBDRIVER_OPTION_ARGS and add Firefox libs to Dockerfile Mar 17, 2023
@nytai nytai merged commit e3a7d20 into master Mar 17, 2023
@nytai nytai deleted the nytai-patch-2 branch March 17, 2023 04:13
@eschutho eschutho added the v2.1 label Mar 20, 2023
@mistercrunch mistercrunch added 🚢 3.0.2 🍒 2.1.1 🍒 2.1.0 🚢 3.0.1 🍒 2.1.2 🍒 2.1.3 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 and removed 🚢 3.0.2 🚢 3.0.1 labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.1 🍒 2.1.0 🍒 2.1.1 🍒 2.1.2 🍒 2.1.3 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants