-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update default WEBDRIVER_OPTION_ARGS and add Firefox libs to Dockerfile #23388
Conversation
Codecov Report
@@ Coverage Diff @@
## master #23388 +/- ##
===========================================
+ Coverage 56.27% 67.58% +11.31%
===========================================
Files 1907 1907
Lines 73495 73531 +36
Branches 7977 7981 +4
===========================================
+ Hits 41356 49698 +8342
+ Misses 30091 21785 -8306
Partials 2048 2048
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 295 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! @nytai!
SUMMARY
This default arg doesn't work with newer versions of the geckodriver. We should remove it so alerts/report/thumbnails work out of the box
Additionally, the upgrade on the firefox drivers broke the dev image's support of these features. This PR adds the missing libs required to make firefox work in the dev image.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION