Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): three typos #23403

Merged
merged 1 commit into from
Mar 17, 2023
Merged

chore(docs): three typos #23403

merged 1 commit into from
Mar 17, 2023

Conversation

rusackas
Copy link
Member

@rusackas rusackas commented Mar 17, 2023

SUMMARY

Three little typos. Hat tip to @sfirke for the eagle eyes!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

n/a

TESTING INSTRUCTIONS

read the diff :)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 17, 2023

Codecov Report

Merging #23403 (6d5add0) into master (635ac8e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #23403   +/-   ##
=======================================
  Coverage   67.58%   67.58%           
=======================================
  Files        1907     1907           
  Lines       73531    73531           
  Branches     7981     7981           
=======================================
  Hits        49698    49698           
  Misses      21785    21785           
  Partials     2048     2048           
Flag Coverage Δ
hive 52.76% <ø> (ø)
javascript 53.82% <ø> (ø)
mysql 78.45% <ø> (ø)
postgres 78.52% <ø> (ø)
presto 52.68% <ø> (ø)
python 82.30% <ø> (ø)
sqlite 77.00% <ø> (ø)
unit 52.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sfirke
Copy link
Member

sfirke commented Mar 17, 2023

Nice! I had reported these in BugHerd (trying that out) so you can close those tickets there.

@rusackas
Copy link
Member Author

Ahh, I misattributed the thanks - if you reported them, then thank you! Correcting my PR notes ;)

@rusackas rusackas merged commit 2feb599 into master Mar 17, 2023
@rusackas rusackas deleted the three-little-typos branch May 11, 2023 16:56
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants