Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(echarts): Add x axis sort by to all series charts #23450

Merged
merged 1 commit into from
Mar 22, 2023

Conversation

kgabryje
Copy link
Member

SUMMARY

Previously, sorting categorical X Axis was available only in Bar Chart. This PR adds the feature to the rest of series charts (Line, Area, Scatter, Smooth, Step)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding to all charts.

@codecov
Copy link

codecov bot commented Mar 22, 2023

Codecov Report

Merging #23450 (422b395) into master (7ef06b0) will increase coverage by 1.86%.
The diff coverage is 60.00%.

❗ Current head 422b395 differs from pull request most recent head e769eba. Consider uploading reports for the commit e769eba to get more accurate results

@@            Coverage Diff             @@
##           master   #23450      +/-   ##
==========================================
+ Coverage   65.76%   67.63%   +1.86%     
==========================================
  Files        1908     1908              
  Lines       73726    73733       +7     
  Branches     7989     7989              
==========================================
+ Hits        48489    49871    +1382     
+ Misses      23189    21814    -1375     
  Partials     2048     2048              
Flag Coverage Δ
javascript 53.82% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 40.00% <ø> (ø)
...harts/src/Timeseries/Regular/Line/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 40.00% <ø> (ø)
...src/Timeseries/Regular/SmoothLine/controlPanel.tsx 40.00% <ø> (ø)
...chart-echarts/src/Timeseries/Step/controlPanel.tsx 33.33% <ø> (ø)
...frontend/src/SqlLab/components/SqlEditor/index.jsx 56.68% <0.00%> (ø)
superset/tasks/thumbnails.py 36.36% <0.00%> (-2.67%) ⬇️
superset/charts/commands/delete.py 92.68% <100.00%> (+0.37%) ⬆️
superset/datasets/commands/delete.py 97.29% <100.00%> (+0.15%) ⬆️

... and 94 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@kgabryje kgabryje merged commit 8ecf0b1 into apache:master Mar 22, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants