Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dashboards): apply tag filter correctly #23521

Merged
merged 1 commit into from
Mar 29, 2023
Merged

Conversation

akzarma
Copy link
Contributor

@akzarma akzarma commented Mar 29, 2023

SUMMARY

Fixes #23520 - the wrong operator (chart_tags instead of dashboard_tags) assigned to tag filter of dashboards page

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:

  • dashboards getting filtered correctly

image

TESTING INSTRUCTIONS

  • Select a tag filter on dashboards page, it should correctly filter the dashboard list on the basis of selected tag in filter dropdown

ADDITIONAL INFORMATION

  • Has associated issue: Dashboards can not be filtered on tags #23520
  • Required feature flags: TAGGING_SYSTEM
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the fix!

@codecov
Copy link

codecov bot commented Mar 29, 2023

Codecov Report

Merging #23521 (714b75c) into master (5d910aa) will increase coverage by 0.00%.
The diff coverage is n/a.

❗ Current head 714b75c differs from pull request most recent head 5c79f12. Consider uploading reports for the commit 5c79f12 to get more accurate results

@@           Coverage Diff           @@
##           master   #23521   +/-   ##
=======================================
  Coverage   67.63%   67.63%           
=======================================
  Files        1910     1910           
  Lines       73746    73748    +2     
  Branches     7987     7988    +1     
=======================================
+ Hits        49878    49880    +2     
  Misses      21826    21826           
  Partials     2042     2042           
Flag Coverage Δ
javascript 53.85% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...uperset-frontend/src/pages/DashboardList/index.tsx 55.73% <ø> (ø)

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@villebro villebro merged commit 542bf25 into apache:master Mar 29, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboards can not be filtered on tags
3 participants