feat: drill by display chart #23524
Merged
feat: drill by display chart #23524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lilykuang
changed the title
lilykuang
changed the title
kgabryje
reviewed
Mar 30, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 30, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 30, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 30, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
lilykuang
force-pushed
the
lily/drill-by-chart
branch
from
5b3c1a5
to
911f7e0
Compare
kgabryje
reviewed
Mar 31, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 31, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 31, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 31, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Mar 31, 2023
| > | ||
| {chartDataResult ? ( | ||
| <SuperChart | ||
| behaviors={[Behavior.INTERACTIVE_CHART]} |
There was a problem hiding this comment.
INTERACTIVE_CHART is for cross filters, and in the drill by modal we only want to support further drill by... but let's leave it for a separate pr to clean up 🙂
lilykuang
force-pushed
the
lily/drill-by-chart
branch
from
d9a0e9b
to
8b684d1
Compare
lilykuang
changed the title
Codecov Report
@@ Coverage Diff @@
## master #23524 +/- ##
==========================================
- Coverage 67.68% 67.62% -0.07%
==========================================
Files 1914 1916 +2
Lines 73962 74009 +47
Branches 8029 8038 +9
==========================================
- Hits 50064 50046 -18
- Misses 21852 21913 +61
- Partials 2046 2050 +4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
kgabryje
reviewed
Apr 3, 2023
| 'glob:*api/v1/chart/data?form_data=%7B%22slice_id%22%3A18%7D'; | ||
|
|
||
| const chart = chartQueries[sliceId]; | ||
| // const fetchWithData = () => { |
There was a problem hiding this comment.
Could you remove commented code?
kgabryje
reviewed
Apr 3, 2023
| expect(await screen.findByText('No Results')).toBeInTheDocument(); | ||
| }); | ||
|
|
||
| // test('should render SuperChart', async () => { |
There was a problem hiding this comment.
Should this test be fixed/uncommented before merging or should it be removed?
There was a problem hiding this comment.
I couldn't get the test to work. i will remove it
kgabryje
reviewed
Apr 3, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByChart.tsx
Outdated
Show resolved
Hide resolved
kgabryje
reviewed
Apr 3, 2023
superset-frontend/src/components/Chart/DrillBy/DrillByMenuItems.tsx
Outdated
Show resolved
Hide resolved
kgabryje
approved these changes
Apr 4, 2023
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATE
Screen.Recording.2023-03-31.at.11.10.10.AM.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION