Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Enables GENERIC_CHART_AXES by default #23652

Merged

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Enables GENERIC_CHART_AXES by default.

This is a task of the Superset 3.0 initiative.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Apr 11, 2023
@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #23652 (a999e46) into master (976e333) will not change coverage.
The diff coverage is n/a.

❗ Current head a999e46 differs from pull request most recent head cf1b20f. Consider uploading reports for the commit cf1b20f to get more accurate results

@@           Coverage Diff           @@
##           master   #23652   +/-   ##
=======================================
  Coverage   68.08%   68.08%           
=======================================
  Files        1920     1920           
  Lines       73984    73984           
  Branches     8092     8092           
=======================================
  Hits        50374    50374           
  Misses      21539    21539           
  Partials     2071     2071           
Flag Coverage Δ
hive 53.16% <ø> (ø)
javascript 54.10% <ø> (ø)
mysql 79.21% <ø> (ø)
postgres 79.29% <ø> (ø)
presto 53.08% <ø> (ø)
python 83.14% <ø> (ø)
sqlite 77.78% <ø> (ø)
unit 53.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/config.py 91.86% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member

Thanks! Re-running the Presto testos.

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to see this finally happening 😍👍

@michael-s-molina michael-s-molina force-pushed the set-generic-chart-axes-true branch from a95ae63 to cf1b20f Compare April 12, 2023 20:06
@michael-s-molina michael-s-molina merged commit 0974fa1 into apache:master Apr 13, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants