fix(sqllab): infinite running state on disconnect #23669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
If you have an existing sqllab browser tab open and for whatever reason get disconnected from the vpn and issue a query, that query tab will forever be suck in a "running/pending" state and fail to stop.
The issue is that the query request never reaches the server; whereas, it is recorded in local storage.
This commit adds the clearInactiveQuery action to clean up the queries that never connected with the server and then batches the action on QueryAutoRefresh logic.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
After:
after--infinite-query-running.mov
Before:
before--infinite-query-running.mov
TESTING INSTRUCTIONS
SQLLAB_BACKEND_PERSISTENCE
FalseADDITIONAL INFORMATION