Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: format timestamps in drill by breadcrumbs #23698

Merged
merged 10 commits into from
Apr 27, 2023

Conversation

lilykuang
Copy link
Member

@lilykuang lilykuang commented Apr 14, 2023

SUMMARY

  • format timestamps in breadcrumbs for drill by

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
Screenshot 2023-04-17 at 10 44 41 AM
After
Screenshot 2023-04-17 at 10 46 06 AM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@lilykuang lilykuang requested a review from kgabryje April 14, 2023 23:42
@lilykuang lilykuang marked this pull request as ready for review April 17, 2023 17:47
@pull-request-size pull-request-size bot added size/M and removed size/L labels Apr 18, 2023
@codecov
Copy link

codecov bot commented Apr 21, 2023

Codecov Report

Merging #23698 (9575060) into master (b92ace4) will increase coverage by 0.14%.
The diff coverage is 80.33%.

❗ Current head 9575060 differs from pull request most recent head e4d077d. Consider uploading reports for the commit e4d077d to get more accurate results

@@            Coverage Diff             @@
##           master   #23698      +/-   ##
==========================================
+ Coverage   67.87%   68.02%   +0.14%     
==========================================
  Files        1925     1936      +11     
  Lines       74389    74935     +546     
  Branches     8108     8141      +33     
==========================================
+ Hits        50494    50974     +480     
- Misses      21818    21873      +55     
- Partials     2077     2088      +11     
Flag Coverage Δ
javascript 54.29% <70.93%> (+0.18%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin-chart-echarts/src/BoxPlot/transformProps.ts 55.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx 0.00% <ø> (ø)
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.71% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx 0.00% <0.00%> (ø)
...lugin-chart-echarts/src/Sunburst/transformProps.ts 0.00% <ø> (ø)
...chart-echarts/src/Timeseries/EchartsTimeseries.tsx 0.00% <0.00%> (ø)
...gin-chart-echarts/src/Timeseries/transformProps.ts 56.75% <ø> (ø)
... and 36 more

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A comment to ensure charts a future proofed for GENERIC_CHART_AXES, which is nowadays set to True by default

op: '==',
val: node.name,
formattedVal: formatSeriesName(node.name, {
timeFormatter: getTimeFormatter(node.name),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The argument of getTimeFormatter/getNumberFormatter should be the time/number format selected by the user, available in formData.dateFormat/formData.numberFormat (or sth similar, not sure if the field name is the same for all charts)

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lilykuang lilykuang merged commit 0bf8907 into apache:master Apr 27, 2023
@lilykuang lilykuang deleted the lily/fix-drillby-timestamps branch April 27, 2023 16:17
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants