Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: npm run dev-server error resolved #23702

Merged

Conversation

Abhishek-kumar-samsung
Copy link
Contributor

This error was coming with me, and 3-4 other pc's in which i tried to setup.

Error: You must provide the URL of lib/mappings.wasm by calling SourceMapConsumer.initialize({ 'lib/mappings.wasm': ... }) before using SourceMapConsumer at readWasm (/home/test/superset_setup/superset/superset-frontend/node_modules/react-hot-loader/node_modules/source-map/lib/read-wasm.js:8:13) at wasm (/home/test/superset_setup/superset/superset-frontend/node_modules/react-hot-loader/node_modules/source-map/lib/wasm.js:25:16) at /home/test/superset_setup/superset/superset-frontend/node_modules/react-hot-loader/node_modules/source-map/lib/source-map-consumer.js:264:14

How to reproduce:

  1. Try fresh installation
  2. after superset/superset-frontend when you will do npm run dev-server , then above error will come.

Above error was also resolved by doing this:
export NODE_OPTIONS=--no-experimental-fetch

But i thought it is better to put in code.

@codecov
Copy link

codecov bot commented Apr 16, 2023

Codecov Report

Merging #23702 (c6c2cde) into master (2a01aa6) will increase coverage by 0.01%.
The diff coverage is 65.37%.

❗ Current head c6c2cde differs from pull request most recent head a2df3a6. Consider uploading reports for the commit a2df3a6 to get more accurate results

@@            Coverage Diff             @@
##           master   #23702      +/-   ##
==========================================
+ Coverage   68.09%   68.11%   +0.01%     
==========================================
  Files        1922     1938      +16     
  Lines       74056    74973     +917     
  Branches     8104     8141      +37     
==========================================
+ Hits        50431    51068     +637     
- Misses      21550    21826     +276     
- Partials     2075     2079       +4     
Flag Coverage Δ
javascript 54.47% <60.80%> (+0.33%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-chart-controls/src/fixtures.ts 100.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...plugin-chart-echarts/src/BoxPlot/transformProps.ts 55.00% <ø> (ø)
...ns/plugin-chart-echarts/src/Graph/EchartsGraph.tsx 0.00% <ø> (ø)
...rts/src/MixedTimeseries/EchartsMixedTimeseries.tsx 0.00% <ø> (ø)
...hart-echarts/src/MixedTimeseries/transformProps.ts 0.00% <0.00%> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.71% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <ø> (ø)
...gin-chart-echarts/src/Sunburst/EchartsSunburst.tsx 0.00% <0.00%> (ø)
... and 118 more

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Abhishek-kumar-samsung
Copy link
Contributor Author

@lilykuang @michael-s-molina @villebro @rusackas @eschutho @geido i have added one change to solve one error that was coming while running npm run dev-server, to run superset-frontend.

Please review.

@rusackas
Copy link
Member

When you say "PCs" do you mean Windows machines? I haven't run into this on Mac, so I'm trying to understand the nature of the error, so I can better understand why this change is needed.

@Abhishek-kumar-samsung
Copy link
Contributor Author

When you say "PCs" do you mean Windows machines? I haven't run into this on Mac, so I'm trying to understand the nature of the error, so I can better understand why this change is needed.

I tried on linux machines.

@eschutho
Copy link
Member

eschutho commented Apr 28, 2023

@Abhishek-kumar-samsung can you add this environment variable to your local/dev/production machines instead as an option? It may be a more flexible option here, in case the rest of the application uses these fetch commands, which I did find some in a quick code search.

Maybe we can add a note in CONTRIBUTING.md for anyone who runs into this issue.

@Abhishek-kumar-samsung
Copy link
Contributor Author

@eschutho @rusackas

I have removed the changes from package.json and moved it to documentation. Written if that error comes to anyone, then he/she can use the solution.

Please review.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for capturing this for the sake of others!

@rusackas rusackas merged commit fd3030f into apache:master Apr 30, 2023
@Abhishek-kumar-samsung Abhishek-kumar-samsung deleted the npm_dev_build_error_resolved branch January 13, 2024 18:24
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants