Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ace-editor): use monospace fonts by default #23747

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

villebro
Copy link
Member

SUMMARY

Currently the adhoc popovers use a non-monospaced font on Safari, causing misplaced cursors when the statement contains bolded elements. This was not an issue in SQL Lab, which applied a custom font family. This PR moves the SQL Lab font family config into the main ACE Editor component, ensuring that all editors have the same font family.

AFTER

Now the bolded elements no longer cause the cursor to lag behind:

ace-after.mp4

SQL Lab is unchanged:

image

BEFORE

Before the cursor would fall behind when there were bolded elements in the statement:

ace-before.mp4

SQL Lab before:

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@villebro
Copy link
Member Author

/testenv up

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-actions
Copy link
Contributor

@villebro Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

@villebro Ephemeral environment creation failed. Please check the Actions logs for details.

@villebro villebro merged commit b2b8c3e into apache:master Apr 20, 2023
@villebro villebro deleted the villebro/safari-monospace branch April 20, 2023 13:24
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants