fix: allow db driver distinction on enforced URI params #23769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
villebro
approved these changes
Apr 21, 2023
Comment on lines
-178
to
+185
| disallow_uri_query_params = {"local_infile"} | ||
| enforce_uri_query_params = {"local_infile": 0} | ||
| disallow_uri_query_params = { | ||
| "mysqldb": {"local_infile"}, | ||
| "mysqlconnector": {"allow_local_infile"}, | ||
| } | ||
| enforce_uri_query_params = { | ||
| "mysqldb": {"local_infile": 0}, | ||
| "mysqlconnector": {"allow_local_infile": 0}, | ||
| } |
There was a problem hiding this comment.
thinking out loud: would it be convenient to be able to specify globally disallowed params, too? Something like this:
disallow_uri_query_params = {
"": {"my_globally_disallowed_param"},
"mysqldb": {"local_infile"},
"mysqlconnector": {"allow_local_infile"},
}(feel free to ignore this idea, as it looks pretty awful 😆)
Codecov Report
@@ Coverage Diff @@
## master #23769 +/- ##
==========================================
- Coverage 67.87% 67.83% -0.04%
==========================================
Files 1924 1924
Lines 74379 74381 +2
Branches 8106 8106
==========================================
- Hits 50484 50457 -27
- Misses 21818 21847 +29
Partials 2077 2077
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 12 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
eschutho
pushed a commit
that referenced
this pull request
May 25, 2023
(cherry picked from commit 6ae5388)
eschutho
added a commit
that referenced
this pull request
May 30, 2023
eschutho
pushed a commit
that referenced
this pull request
Jun 2, 2023
eschutho
pushed a commit
that referenced
this pull request
Jun 14, 2023
mistercrunch
added
🍒 2.1.1
🍒 2.1.2
🍒 2.1.3
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Parameters on SQLAlchemy URI vary by driver. Currently connections using "mysql+mysqlconnector" break because the engine spec is enforcing an unknown parameter for this driver.
This PR fixes this issue introducing the driver name to
disallow_uri_query_paramsandenforce_uri_query_paramsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION