fix(datasource): saving new calculated columns #23783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #23783 +/- ##
==========================================
+ Coverage 67.87% 67.95% +0.07%
==========================================
Files 1925 1933 +8
Lines 74389 74752 +363
Branches 8108 8108
==========================================
+ Hits 50494 50799 +305
- Misses 21818 21876 +58
Partials 2077 2077
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Hello! |
jfrag1
approved these changes
Apr 24, 2023
kgabryje
reviewed
Apr 24, 2023
| @@ -139,7 +139,7 @@ const DatasourceModal: FunctionComponent<DatasourceModalProps> = ({ | |||
| ), | |||
| columns: currentDatasource?.columns?.map( | |||
| (column: Record<string, unknown>) => ({ | |||
| id: column.id, | |||
| id: typeof column.id !== 'string' ? column.id : undefined, | |||
There was a problem hiding this comment.
Since we only accept Number or undefined, maybe it'd be more clear to compare to 'number'? Like typeof column.id === 'number' ? column.id : undefined
…ues (apache#23779)" This reverts commit 4b3e507.
eschutho
approved these changes
Apr 24, 2023
jinghua-qa
pushed a commit
to preset-io/superset
that referenced
this pull request
Apr 27, 2023
(cherry picked from commit 742c2cd)
sebastianliebscher
pushed a commit
to sebastianliebscher/superset
that referenced
this pull request
Apr 28, 2023
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
May 5, 2023
This reverts commit 742c2cd.
sadpandajoe
added a commit
to preset-io/superset
that referenced
this pull request
May 12, 2023
This reverts commit 742c2cd.
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Creating a new calculated columns isn't working.
Because the datasource is receiving a string ID from the frontend, which is resulting in invalid input.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
2023-04-22_19-18-21.mp4
After
2023-04-22_19-15-44.mp4
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION
CC @jfrag1 #23678