Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: cleanup references to apache-superset/superset-ui #23796

Conversation

charpeni
Copy link
Contributor

SUMMARY

It seems like packages from superset-frontend used to live in apache-superset/superset-ui, but the repository was archived, and content has been imported here.

Unfortunately, they still contain multiple references to the legacy repository, including links in package.json that are used by npm. It means that published packages on npm are still linking to the archived repository saying to not use it anymore.

To remove that confusion, I've renamed all references to apache-superset/superset-ui and cleaned up relevant fields in package.json to better support a monorepo.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a little fuzzy on if there's any need for the git+https:// that was there, but I see no reason to object to the proposed change. Everything else looks great!

Thank you for the PR, I/we appreciate all the help and cleanup here! Please feel free to join us on the #documentation channel over on Superset Slack if you'd like to join us in tackling more documentation-oriented efforts like these.

@codecov
Copy link

codecov bot commented Apr 24, 2023

Codecov Report

Merging #23796 (1de4bd6) into master (6ae5388) will not change coverage.
The diff coverage is n/a.

❗ Current head 1de4bd6 differs from pull request most recent head 7731cd8. Consider uploading reports for the commit 7731cd8 to get more accurate results

@@           Coverage Diff           @@
##           master   #23796   +/-   ##
=======================================
  Coverage   67.86%   67.86%           
=======================================
  Files        1926     1926           
  Lines       74498    74498           
  Branches     8108     8108           
=======================================
  Hits        50555    50555           
  Misses      21866    21866           
  Partials     2077     2077           
Flag Coverage Δ
javascript 54.10% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas rusackas merged commit 60c2e70 into apache:master Apr 25, 2023
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
@charpeni charpeni deleted the rename-references-to-apache-superset-superset-ui branch May 11, 2023 14:01
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants