Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump redis to 4.5.4 #23845

Merged
merged 2 commits into from
Apr 28, 2023
Merged

Conversation

EugeneTorap
Copy link
Contributor

@EugeneTorap EugeneTorap commented Apr 27, 2023

SUMMARY

Bump the redis lib from 3.5.3 to 4.5.4
Bump the psycopg2 lib to 2.9.6
Use CACHE_TYPE - RedisCache everywhere
Also fix the next CVE:
Dependency pypi:redis:3.5.3 is vulnerable
CVE-2023-28858 9.8 Improper Access Control vulnerability pending CVSS allocation

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 27, 2023

Codecov Report

Merging #23845 (8c11420) into master (053dca1) will decrease coverage by 0.03%.
The diff coverage is n/a.

❗ Current head 8c11420 differs from pull request most recent head 3618361. Consider uploading reports for the commit 3618361 to get more accurate results

@@            Coverage Diff             @@
##           master   #23845      +/-   ##
==========================================
- Coverage   68.11%   68.08%   -0.03%     
==========================================
  Files        1938     1938              
  Lines       74958    74958              
  Branches     8141     8141              
==========================================
- Hits        51055    51036      -19     
- Misses      21824    21843      +19     
  Partials     2079     2079              
Flag Coverage Δ
hive 53.01% <ø> (ø)
mysql 78.80% <ø> (ø)
postgres 78.87% <ø> (ø)
presto 52.92% <ø> (ø)
python 82.62% <ø> (-0.06%) ⬇️
sqlite ?
unit 52.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@craig-rueda
Copy link
Member

Looks like there's some failed checks after bumping things

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@villebro villebro merged commit dab038c into apache:master Apr 28, 2023
@EugeneTorap EugeneTorap deleted the chore/bump-redis-lib branch April 28, 2023 08:52
sebastianliebscher pushed a commit to sebastianliebscher/superset that referenced this pull request Apr 28, 2023
sinhashubham95 added a commit to sinhashubham95/superset that referenced this pull request May 4, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants