Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove deprecated distutils #24001

Merged
merged 11 commits into from
May 11, 2023

Conversation

sebastianliebscher
Copy link
Contributor

@sebastianliebscher sebastianliebscher commented May 10, 2023

SUMMARY

Distutils is deprecated. Followed the migration advice.

  • Replaces distutils.version with packaging.version
  • Implements distutils.utils strtobool in superset.utils core.py with a unit test
  • Implements numpy.distutils is_sequence in flatten.py
  • Modified requirements with pip-compile-multi -P packaging

Note: Could not bump packaging because of dependency google-cloud-bigquery

TESTING INSTRUCTIONS

tox -e py38

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Merging #24001 (7d83b61) into master (e3719a1) will increase coverage by 0.09%.
The diff coverage is 92.85%.

❗ Current head 7d83b61 differs from pull request most recent head 8d1366f. Consider uploading reports for the commit 8d1366f to get more accurate results

@@            Coverage Diff             @@
##           master   #24001      +/-   ##
==========================================
+ Coverage   68.13%   68.22%   +0.09%     
==========================================
  Files        1941     1941              
  Lines       75304    75303       -1     
  Branches     8166     8165       -1     
==========================================
+ Hits        51308    51376      +68     
+ Misses      21907    21838      -69     
  Partials     2089     2089              
Flag Coverage Δ
hive 53.18% <42.85%> (?)
mysql 78.91% <64.28%> (-0.01%) ⬇️
postgres 78.98% <64.28%> (-0.01%) ⬇️
presto 53.10% <42.85%> (ø)
python 82.76% <92.85%> (+0.18%) ⬆️
sqlite 77.50% <64.28%> (-0.01%) ⬇️
unit 53.03% <85.71%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-ui-chart-controls/src/components/ColumnOption.tsx 84.61% <ø> (-1.10%) ⬇️
...et-ui-chart-controls/src/components/labelUtils.tsx 100.00% <ø> (ø)
superset/db_engine_specs/base.py 90.82% <ø> (ø)
superset/db_engine_specs/clickhouse.py 54.87% <0.00%> (ø)
superset/db_engine_specs/databricks.py 70.42% <ø> (ø)
superset/db_engine_specs/snowflake.py 67.25% <ø> (ø)
superset/db_engine_specs/elasticsearch.py 96.55% <100.00%> (ø)
superset/db_engine_specs/presto.py 87.84% <100.00%> (ø)
superset/utils/core.py 90.88% <100.00%> (+0.06%) ⬆️
superset/utils/pandas_postprocessing/flatten.py 100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

superset/utils/core.py Outdated Show resolved Hide resolved
tests/unit_tests/utils/test_core.py Outdated Show resolved Hide resolved
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test style comment, other than that LGTM

tests/unit_tests/utils/test_core.py Outdated Show resolved Hide resolved
Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test style comment, other than that LGTM

Copy link
Member

@dpgaspar dpgaspar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@villebro villebro merged commit c963416 into apache:master May 11, 2023
@EugeneTorap EugeneTorap deleted the remove_distutils branch May 11, 2023 16:18
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request May 22, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants