-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Update mypy and fix stubs issue #24033
chore: Update mypy and fix stubs issue #24033
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24033 +/- ##
=======================================
Coverage 68.21% 68.21%
=======================================
Files 1941 1941
Lines 75259 75261 +2
Branches 8168 8168
=======================================
+ Hits 51341 51343 +2
Misses 21829 21829
Partials 2089 2089
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -55,6 +55,8 @@ def embedded( | |||
if not embedded: | |||
abort(404) | |||
|
|||
assert embedded is not None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mypy doc:
You can often work around these errors by using assert isinstance(obj, ClassName) or assert obj is not None to tell mypy that you know that the type is more specific than what mypy thinks.
SUMMARY
Bump
mypy
from 1.0.1 to 1.3.0Make explicit the
additional_dependencies
for missed stubsFix
mypy
type errorsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION