Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add log for ssh tunnel information #24058

Merged
merged 1 commit into from
May 15, 2023
Merged

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented May 15, 2023

SUMMARY

logging information on the server_context when trying to establish a ssh tunnel

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 15, 2023

Codecov Report

Merging #24058 (65495ca) into master (1670275) will increase coverage by 0.00%.
The diff coverage is 50.00%.

❗ Current head 65495ca differs from pull request most recent head 2ac2a98. Consider uploading reports for the commit 2ac2a98 to get more accurate results

@@           Coverage Diff           @@
##           master   #24058   +/-   ##
=======================================
  Coverage   68.23%   68.23%           
=======================================
  Files        1942     1942           
  Lines       75205    75203    -2     
  Branches     8145     8145           
=======================================
  Hits        51314    51314           
+ Misses      21806    21804    -2     
  Partials     2085     2085           
Flag Coverage Δ
hive 53.18% <50.00%> (-0.01%) ⬇️
mysql 78.93% <50.00%> (-0.01%) ⬇️
postgres 79.01% <50.00%> (-0.01%) ⬇️
presto 53.10% <50.00%> (-0.01%) ⬇️
python 82.78% <50.00%> (-0.01%) ⬇️
sqlite 77.53% <50.00%> (-0.01%) ⬇️
unit 53.02% <50.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...n-chart-handlebars/src/plugin/controls/columns.tsx 17.64% <ø> (+2.64%) ⬆️
superset/models/core.py 89.97% <50.00%> (-0.19%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hold on

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@betodealmeida betodealmeida merged commit de96372 into master May 15, 2023
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 15, 2023
@sadpandajoe
Copy link
Member

🏷️ preset:2023.19

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the hxgh-ssh-port-log branch March 26, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants