Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(docs): upgrading docusaurus (fixes header links) #24118

Merged
merged 1 commit into from
Jun 1, 2023

Conversation

rusackas
Copy link
Member

SUMMARY

Header links, when clicked, were scrolling off page. Upon some digging, it looks like this was fixed and we're due for an upgrade. So... fingers crossed!

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Deploy, then sanity-check the site and the header links. Revert if needed.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #24118 (64d8a9a) into master (2222073) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #24118   +/-   ##
=======================================
  Coverage   68.30%   68.30%           
=======================================
  Files        1952     1952           
  Lines       75432    75432           
  Branches     8191     8191           
=======================================
  Hits        51521    51521           
  Misses      21807    21807           
  Partials     2104     2104           
Flag Coverage Δ
hive 53.17% <ø> (ø)
javascript 54.70% <ø> (ø)
mysql 78.94% <ø> (ø)
postgres 79.01% <ø> (ø)
presto 53.10% <ø> (ø)
python 82.81% <ø> (ø)
sqlite 77.54% <ø> (ø)
unit 53.09% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rusackas
Copy link
Member Author

FWIW, this seems to build find and run in dev mode just fine on my local machine :)

@rusackas rusackas merged commit 7d7ce63 into master Jun 1, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
@mistercrunch mistercrunch deleted the chore(docs)-upgrading-docusaurus branch March 26, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants