Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: db validate parameters permission #24185

Merged
merged 4 commits into from
Jun 5, 2023
Merged

fix: db validate parameters permission #24185

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a76cfa5
fix: db validate parameters permission
dpgaspar May 23, 2023
3dff128
restrict test_connection also
dpgaspar May 23, 2023
25f7956
updated updating
dpgaspar Jun 5, 2023
4e2fd6f
Merge branch 'master' into fix/db-val-param-perms
dpgaspar Jun 5, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions UPDATING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,8 @@ This file documents any backwards-incompatible changes in Superset and
assists people when migrating to a new version.

## Next

- [24185](https://github.com/apache/superset/pull/24185): `/api/v1/database/test_connection` and `api/v1/database/validate_parameters` permissions changed from `can_read` to `can_write`. Only Admin user's have access.
- [24256](https://github.com/apache/superset/pull/24256): `Flask-Login` session validation is now set to `strong` by default. Previous setting was `basic`.
- [24232](https://github.com/apache/superset/pull/24232): Enables ENABLE_TEMPLATE_REMOVE_FILTERS, DRILL_TO_DETAIL, DASHBOARD_CROSS_FILTERS by default, marks VERSIONED_EXPORT and ENABLE_TEMPLATE_REMOVE_FILTERS as deprecated.
- [23652](https://github.com/apache/superset/pull/23652): Enables GENERIC_CHART_AXES feature flag by default.
Expand Down
4 changes: 2 additions & 2 deletions superset/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,8 @@ class RouteMethod: # pylint: disable=too-few-public-methods
"select_star": "read",
"table_metadata": "read",
"table_extra_metadata": "read",
"test_connection": "read",
"validate_parameters": "read",
"test_connection": "write",
"validate_parameters": "write",
"favorite_status": "read",
"add_favorite": "read",
"remove_favorite": "read",
Expand Down