Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typescript warnings when importing types #24217

Conversation

michael-s-molina
Copy link
Member

SUMMARY

This PR fixes Typescript warnings related to importing types. See Type-Only Imports and Export for more information.

The following warnings have been removed:

Screenshot 2023-05-25 at 16 17 25

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #24217 (8fdfd8c) into master (9df8d8d) will increase coverage by 0.01%.
The diff coverage is n/a.

❗ Current head 8fdfd8c differs from pull request most recent head 8273702. Consider uploading reports for the commit 8273702 to get more accurate results

@@            Coverage Diff             @@
##           master   #24217      +/-   ##
==========================================
+ Coverage   68.30%   68.32%   +0.01%     
==========================================
  Files        1957     1957              
  Lines       75594    75594              
  Branches     8224     8224              
==========================================
+ Hits        51637    51651      +14     
+ Misses      21849    21829      -20     
- Partials     2108     2114       +6     
Flag Coverage Δ
javascript 54.76% <ø> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Table/index.tsx 75.29% <ø> (ø)
superset-frontend/src/dashboard/types.ts 100.00% <ø> (ø)
...perset-frontend/src/hooks/apiResources/queryApi.ts 100.00% <ø> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Super happy to see those warnings gone

@michael-s-molina michael-s-molina merged commit 5853574 into apache:master May 31, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants