chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow #24266

john-bodley · 2023-06-01T19:01:27Z

SUMMARY

This PR partially addresses Superset 3.0 task #9 by removing the previous deprecated ENABLE_ACCESS_REQUEST config parameter and the associated workflows.

The TL;DR is this legacy workflow failed to work post #22022 (which mentions that the API endpoint is deprecated and will be removed in 3.0) when the GET requests became POST requests meaning logic like this and this is currently broken.

Honestly I'm going in somewhat blind in terms of the how/where this logic was used, but the TL;DR is there seems to be no approval logic/workflow if there's no request workflows. Hopefully I've trimmed enough dead code without over pruning, though this has turned somewhat into a yak shaving exercise as—by deleting the /approve endpoint—it led to removing facets of role extension, deleting the granter role, etc.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

CI.

ADDITIONAL INFORMATION

Has associated issue:
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

john-bodley · 2023-06-01T20:06:38Z

superset/views/core.py

-                    __(security_manager.get_datasource_access_error_msg(datasource)),
-                    "danger",
-                )
-                return redirect(


Note this redirect no longer worked as this is being called via a GET yet the redirect URL only accepts a POST.

codecov · 2023-06-01T20:59:42Z

Codecov Report

Merging #24266 (1263551) into master (4e47771) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 1263551 differs from pull request most recent head dc2a4d1. Consider uploading reports for the commit dc2a4d1 to get more accurate results

@@           Coverage Diff            @@
##           master   #24266    +/-   ##
========================================
  Coverage   69.08%   69.09%            
========================================
  Files        1905     1903     -2     
  Lines       74813    74608   -205     
  Branches     8107     8107            
========================================
- Hits        51686    51550   -136     
+ Misses      21016    20947    -69     
  Partials     2111     2111

Flag	Coverage Δ
hive	`53.79% <100.00%> (+0.10%)`	⬆️
javascript	`55.62% <ø> (ø)`
mysql	`79.39% <100.00%> (+0.07%)`	⬆️
postgres	`79.46% <100.00%> (+0.07%)`	⬆️
presto	`53.71% <100.00%> (+0.10%)`	⬆️
python	`83.38% <100.00%> (+0.09%)`	⬆️
sqlite	`77.99% <100.00%> (+0.06%)`	⬆️
unit	`54.20% <100.00%> (+0.11%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	`91.97% <ø> (-0.03%)`	⬇️
superset/initialization/__init__.py	`91.35% <ø> (-0.06%)`	⬇️
superset/security/manager.py	`95.92% <ø> (-0.02%)`	⬇️
superset/views/__init__.py	`100.00% <ø> (ø)`
superset/views/core.py	`76.24% <ø> (+0.96%)`	⬆️
superset/explore/commands/get.py	`90.42% <100.00%> (+1.65%)`	⬆️
superset/models/__init__.py	`100.00% <100.00%> (ø)`
superset/utils/core.py	`91.55% <100.00%> (-0.05%)`	⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

dpgaspar

It seems that probably makes sense to remove /superset/override_role_permissions also, since it seems related with is granter role. See if you agree and I'll close: #24334

john-bodley · 2023-06-09T01:30:02Z

@dpgaspar I agree with your comment as I went down this path previously but didn't know how far I should go. This also makes the granter role obsolete.

john-bodley · 2023-06-09T06:14:27Z

tests/integration_tests/datasets/api_tests.py

@@ -348,7 +348,7 @@ def test_get_dataset_item(self):
            "sql": None,
            "table_name": "energy_usage",
            "template_params": None,
-            "uid": "2__table",
+            "uid": "6__table",


Love how removing some tests exposed the non-idempotent facets of others.

Since we're only asserting fields that are listed here (see lines 375-377), maybe we can just remove this line? I'm not sure we really need to assert the uid, as I assume doing this assertion will fail when running this test in isolation.

I'll use mock.ANY.

villebro

Great to see this dead code being removed, as this has caused a lot of confusion over the years. If this type of functionality really is needed, it should probably be done slightly differently, using pluggable FAB views/classes etc that don't require this much logic in the main codebase.

villebro · 2023-06-09T08:05:32Z

tests/integration_tests/datasets/api_tests.py

@@ -348,7 +348,7 @@ def test_get_dataset_item(self):
            "sql": None,
            "table_name": "energy_usage",
            "template_params": None,
-            "uid": "2__table",
+            "uid": "6__table",


Since we're only asserting fields that are listed here (see lines 375-377), maybe we can just remove this line? I'm not sure we really need to assert the uid, as I assume doing this assertion will fail when running this test in isolation.

eschutho · 2023-06-12T18:41:39Z

@john-bodley just to be on the safe side, I'm going to mark this as a possible breaking change. Do you think we should add anything to the UPDATING.md file re the changes?

pull-request-size bot added the size/XL label Jun 1, 2023

john-bodley force-pushed the john-bodley--remove-enable-access-request branch 2 times, most recently from 4b422f7 to a7c6abf Compare June 1, 2023 19:17

pull-request-size bot added size/L and removed size/XL labels Jun 1, 2023

john-bodley marked this pull request as ready for review June 1, 2023 20:03

john-bodley commented Jun 1, 2023

View reviewed changes

john-bodley force-pushed the john-bodley--remove-enable-access-request branch from a7c6abf to eeea8c9 Compare June 1, 2023 20:28

pull-request-size bot added size/XL and removed size/L labels Jun 1, 2023

john-bodley force-pushed the john-bodley--remove-enable-access-request branch 3 times, most recently from f949506 to 8c9dd8b Compare June 1, 2023 23:27

john-bodley mentioned this pull request Jun 7, 2023

chore: Remove unused sliceCanEdit logic #24312

Merged

9 tasks

john-bodley force-pushed the john-bodley--remove-enable-access-request branch from 8c9dd8b to fb6f391 Compare June 7, 2023 19:04

john-bodley requested a review from a team as a code owner June 7, 2023 19:04

john-bodley force-pushed the john-bodley--remove-enable-access-request branch 4 times, most recently from 9e825ba to 44f918b Compare June 9, 2023 00:39

dpgaspar reviewed Jun 9, 2023

View reviewed changes

john-bodley force-pushed the john-bodley--remove-enable-access-request branch 2 times, most recently from f2f9cb5 to 17b5020 Compare June 9, 2023 01:28

pull-request-size bot added size/XXL and removed size/XL labels Jun 9, 2023

john-bodley force-pushed the john-bodley--remove-enable-access-request branch 2 times, most recently from d2be248 to 6511cb2 Compare June 9, 2023 06:13

john-bodley commented Jun 9, 2023

View reviewed changes

john-bodley requested review from villebro and michael-s-molina June 9, 2023 07:15

villebro approved these changes Jun 9, 2023

View reviewed changes

john-bodley force-pushed the john-bodley--remove-enable-access-request branch 3 times, most recently from 726adbc to 2d82c46 Compare June 9, 2023 23:05

chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow

dc2a4d1

john-bodley force-pushed the john-bodley--remove-enable-access-request branch from 2d82c46 to dc2a4d1 Compare June 9, 2023 23:06

john-bodley merged commit 0e3f1f6 into apache:master Jun 10, 2023

dpgaspar mentioned this pull request Jun 12, 2023

chore: remove deprecated api /superset/override_role_permissions #24334

Closed

9 tasks

eschutho added the risk:breaking-change Issues or PRs that will introduce breaking changes label Jun 12, 2023

michael-s-molina added the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 12, 2023

michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow #24266

chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow #24266

john-bodley commented Jun 1, 2023 •

edited

Loading

john-bodley Jun 1, 2023

codecov bot commented Jun 1, 2023 •

edited

Loading

dpgaspar left a comment •

edited

Loading

john-bodley commented Jun 9, 2023 •

edited

Loading

john-bodley Jun 9, 2023

villebro Jun 9, 2023

john-bodley Jun 9, 2023

villebro left a comment

villebro Jun 9, 2023

eschutho commented Jun 12, 2023

chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow #24266

chore: Remove deprecated ENABLE_ACCESS_REQUEST workflow #24266

Conversation

john-bodley commented Jun 1, 2023 • edited Loading

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

john-bodley Jun 1, 2023

Choose a reason for hiding this comment

codecov bot commented Jun 1, 2023 • edited Loading

Codecov Report

dpgaspar left a comment • edited Loading

Choose a reason for hiding this comment

john-bodley commented Jun 9, 2023 • edited Loading

john-bodley Jun 9, 2023

Choose a reason for hiding this comment

villebro Jun 9, 2023

Choose a reason for hiding this comment

john-bodley Jun 9, 2023

Choose a reason for hiding this comment

villebro left a comment

Choose a reason for hiding this comment

villebro Jun 9, 2023

Choose a reason for hiding this comment

eschutho commented Jun 12, 2023

john-bodley commented Jun 1, 2023 •

edited

Loading

codecov bot commented Jun 1, 2023 •

edited

Loading

dpgaspar left a comment •

edited

Loading

john-bodley commented Jun 9, 2023 •

edited

Loading