Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Removes getUiOverrideRegistry #24330

Merged

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 8, 2023

SUMMARY

Removes getUiOverrideRegistry from ExtensionsRegistry as part of 3.0 cleanup.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jun 8, 2023
@michael-s-molina michael-s-molina marked this pull request as ready for review June 8, 2023 20:24
@michael-s-molina
Copy link
Member Author

michael-s-molina commented Jun 8, 2023

Pinging @jfrag1 @kgabryje @villebro @justinpark @zhaoyongjie given that this PR may break extensions.

@michael-s-molina michael-s-molina requested review from john-bodley, justinpark and rusackas and removed request for john-bodley June 8, 2023 20:26
@codecov
Copy link

codecov bot commented Jun 8, 2023

Codecov Report

Merging #24330 (2e2e164) into master (c4242a3) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 2e2e164 differs from pull request most recent head 27d20dd. Consider uploading reports for the commit 27d20dd to get more accurate results

@@            Coverage Diff             @@
##           master   #24330      +/-   ##
==========================================
- Coverage   69.08%   69.07%   -0.01%     
==========================================
  Files        1905     1905              
  Lines       74848    74847       -1     
  Branches     8108     8108              
==========================================
- Hits        51705    51704       -1     
  Misses      21031    21031              
  Partials     2112     2112              
Flag Coverage Δ
javascript 55.61% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...set-ui-core/src/ui-overrides/ExtensionsRegistry.ts 100.00% <ø> (ø)
...frontend/src/dashboard/components/Header/index.jsx 59.28% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit bdb8bbe into apache:master Jun 9, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/S 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants