-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Convert ENABLE_BROAD_ACTIVITY_ACCESS and MENU_HIDE_USER_INFO into feature flags #24345
feat: Convert ENABLE_BROAD_ACTIVITY_ACCESS and MENU_HIDE_USER_INFO into feature flags #24345
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24345 +/- ##
==========================================
- Coverage 69.04% 68.91% -0.13%
==========================================
Files 1903 1903
Lines 74564 74558 -6
Branches 8107 8107
==========================================
- Hits 51485 51385 -100
- Misses 20968 21062 +94
Partials 2111 2111
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 9 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f016fdf
to
25a5d53
Compare
25a5d53
to
4c106d0
Compare
SUMMARY
Converts
ENABLE_BROAD_ACTIVITY_ACCESS
andMENU_HIDE_USER_INFO
into feature flags as part of the 3.0 cleanup efforts.ENABLE_BROAD_ACTIVITY_ACCESS
had its default value altered toFalse
as it's more secure.TESTING INSTRUCTIONS
CI should be sufficient.
ADDITIONAL INFORMATION