Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Convert ENABLE_BROAD_ACTIVITY_ACCESS and MENU_HIDE_USER_INFO into feature flags #24345

Merged
merged 7 commits into from
Jun 12, 2023

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jun 9, 2023

SUMMARY

Converts ENABLE_BROAD_ACTIVITY_ACCESS and MENU_HIDE_USER_INFO into feature flags as part of the 3.0 cleanup efforts.

ENABLE_BROAD_ACTIVITY_ACCESS had its default value altered to False as it's more secure.

TESTING INSTRUCTIONS

CI should be sufficient.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina added risk:breaking-change Issues or PRs that will introduce breaking changes v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch labels Jun 9, 2023
@michael-s-molina michael-s-molina marked this pull request as ready for review June 9, 2023 15:10
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Merging #24345 (407414b) into master (e0253a4) will decrease coverage by 0.13%.
The diff coverage is 88.88%.

❗ Current head 407414b differs from pull request most recent head 6081069. Consider uploading reports for the commit 6081069 to get more accurate results

@@            Coverage Diff             @@
##           master   #24345      +/-   ##
==========================================
- Coverage   69.04%   68.91%   -0.13%     
==========================================
  Files        1903     1903              
  Lines       74564    74558       -6     
  Branches     8107     8107              
==========================================
- Hits        51485    51385     -100     
- Misses      20968    21062      +94     
  Partials     2111     2111              
Flag Coverage Δ
hive ?
javascript 55.61% <100.00%> (-0.01%) ⬇️
mysql 79.35% <85.71%> (?)
postgres 79.42% <85.71%> (+<0.01%) ⬆️
presto ?
python 83.04% <85.71%> (-0.27%) ⬇️
sqlite 77.94% <71.42%> (-0.01%) ⬇️
unit 54.20% <28.57%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
superset/config.py 91.93% <ø> (-0.05%) ⬇️
superset/views/base.py 77.21% <ø> (ø)
superset/views/core.py 75.68% <ø> (+0.25%) ⬆️
superset/models/filter_set.py 77.27% <50.00%> (-0.34%) ⬇️
superset-frontend/src/pages/ChartList/index.tsx 55.00% <100.00%> (-0.32%) ⬇️
...uperset-frontend/src/pages/DashboardList/index.tsx 55.37% <100.00%> (-0.37%) ⬇️
superset/connectors/sqla/models.py 88.65% <100.00%> (-0.99%) ⬇️
superset/models/dashboard.py 78.92% <100.00%> (-0.09%) ⬇️
superset/models/slice.py 87.73% <100.00%> (-0.06%) ⬇️
... and 1 more

... and 9 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@michael-s-molina michael-s-molina force-pushed the configs-to-feature-flags branch from f016fdf to 25a5d53 Compare June 9, 2023 16:03
@michael-s-molina michael-s-molina force-pushed the configs-to-feature-flags branch from 25a5d53 to 4c106d0 Compare June 9, 2023 16:04
@john-bodley john-bodley merged commit a7f7f66 into apache:master Jun 12, 2023
@michael-s-molina michael-s-molina removed the v3.0 Label added by the release manager to track PRs to be included in the 3.0 branch label Jun 26, 2023
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.0.0 labels Mar 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels risk:breaking-change Issues or PRs that will introduce breaking changes size/L 🚢 3.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants