chore: deprecate FLASK_ENV and improve conf.ENVIRONMENT_TAG_CONFIG

[mistercrunch]

Flask is deprecating FLASK_ENV, leading to this msg in the interpreter:

'FLASK_ENV' is deprecated and will not be used in Flask 2.3. Use 'FLASK_DEBUG' instead.

SUMMARY

Moving away from using FLASK_ENV and creating a SUPERSET_ENV instead. Cleaning up the code around the configuration ENVIRONMENT_TAG_CONFIG too that relied on that.

Adding a note on UPDATING.md at it may affect some environments, mostly should just affect whether and how that warning tag in the navbar shows up.

TESTED

• export SUPERSET_ENV=development leads to Development tag showing in navbar
• export SUPERSET_ENV=production leads to no tag showing in navbar
• unset SUPERSET_ENV leads to flask-debug tag in navbar
• export SUPERSET_ENV=giberrish leads to flask-debug tag in navbar
• tested custom "amazing" config

ENVIRONMENT_TAG_CONFIG = {
    "variable": "SUPERSET_ENV",
    "values": {
        "debug": {
            "color": "error.base",
            "text": "flask-debug",
        },
        "amazing": {
            "color": "warning.base",
            "text": "AMAZING",
        },
    },
}

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

[codecov]

Codecov Report

Merging #24404 (8824f3c) into master (884a8b5) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 8824f3c differs from pull request most recent head 0844faf. Consider uploading reports for the commit 0844faf to get more accurate results

@@           Coverage Diff           @@
##           master   #24404   +/-   ##
=======================================
  Coverage   68.93%   68.93%           
=======================================
  Files        1904     1904           
  Lines       73880    73886    +6     
  Branches     8119     8119           
=======================================
+ Hits        50929    50935    +6     
  Misses      20840    20840           
  Partials     2111     2111           

Flag	Coverage Δ
hive	53.95% <100.00%> (+<0.01%)	⬆️
javascript	55.65% <ø> (ø)
mysql	79.25% <100.00%> (+<0.01%)	⬆️
postgres	79.34% <100.00%> (+<0.01%)	⬆️
presto	53.87% <100.00%> (+<0.01%)	⬆️
python	83.33% <100.00%> (+<0.01%)	⬆️
sqlite	77.84% <100.00%> (+<0.01%)	⬆️
unit	54.64% <18.18%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/config.py	91.97% <100.00%> (ø)
superset/views/base.py	73.33% <100.00%> (+0.54%)	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[dpgaspar]

Nice!

[rusackas]

Two questions on this one:

1. Do we need to pull the thread on the sweater and tackle all this other stuff? Particularly the contributing docs:

2. Does this create issues and edge cases around scripts and automation that might be considered a breaking change by some?