Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: Transition of Navbar from dark to light and vice-versa is now smooth #24485

Merged
merged 1 commit into from
Nov 15, 2023
Merged

style: Transition of Navbar from dark to light and vice-versa is now smooth #24485

merged 1 commit into from
Nov 15, 2023

Conversation

git-init-priyanshu
Copy link
Contributor

@git-init-priyanshu git-init-priyanshu commented Jun 22, 2023 •
edited
Loading

Fixes issue #24478

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Included in the issue itself

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

github-actions[bot]
github-actions bot reviewed Jun 22, 2023
View reviewed changes
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@john-bodley john-bodley requested review from michael-s-molina and removed request for michael-s-molina June 23, 2023 16:50
@git-init-priyanshu git-init-priyanshu changed the title UI: Transition of Navbar from dark to light and vice-versa is now smooth style: Transition of Navbar from dark to light and vice-versa is now smooth Jul 21, 2023
@rusackas
Copy link
Member

rusackas commented Nov 6, 2023

closing/reopening to kick-start CI. Hopefully this passes.

@rusackas rusackas closed this Nov 6, 2023
@rusackas rusackas reopened this Nov 6, 2023
@rusackas rusackas merged commit 63b8172 into apache:master Nov 15, 2023
30 checks passed
josedev-union pushed a commit to Ortege-xyz/studio that referenced this pull request Jan 22, 2024
@git-init-priyanshu @josedev-union
style: Transition of Navbar from dark to light and vice-versa is now …
3200d2e 
…smooth (apache#24485)
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@git-init-priyanshu
style: Transition of Navbar from dark to light and vice-versa is now …
337c653 
…smooth (apache#24485)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 labels Mar 8, 2024
sfirke pushed a commit to sfirke/superset that referenced this pull request Mar 22, 2024
@git-init-priyanshu @sfirke
style: Transition of Navbar from dark to light and vice-versa is now …
ed8d1f3 
…smooth (apache#24485)
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
@git-init-priyanshu
style: Transition of Navbar from dark to light and vice-versa is now …
5180200 
…smooth (apache#24485)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@rusackas rusackas rusackas approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@git-init-priyanshu @rusackas @mistercrunch