-
Notifications
You must be signed in to change notification settings - Fork 13.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(charts): big-number display broken in echarts #24492
fix(charts): big-number display broken in echarts #24492
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff, this has been a pain for a long time! A few minor comments.
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/index.test.ts
Outdated
Show resolved
Hide resolved
superset-frontend/plugins/plugin-chart-echarts/test/Timeseries/index.test.ts
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #24492 +/- ##
==========================================
+ Coverage 69.01% 69.04% +0.03%
==========================================
Files 1901 1903 +2
Lines 74034 74027 -7
Branches 8119 8118 -1
==========================================
+ Hits 51091 51109 +18
+ Misses 20835 20807 -28
- Partials 2108 2111 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@justinpark I know that you fixed similar problems recently. Could you review this PR? |
SUMMARY
The current implementation of the time-series charts in ECharts seems to have a limitation in properly rendering big numbers. As a result, the display of big numbers in the chart is broken.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
After:
TESTING INSTRUCTIONS
To replicate the issue with big number display in time series charts, you can create a time series chart that includes data points with large numeric values. Here is an example SQL query that can be executed in SQL Lab to generate such data: