-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Deque mutated during iteration #24550
fix: Deque mutated during iteration #24550
Conversation
Codecov Report
@@ Coverage Diff @@
## master #24550 +/- ##
==========================================
+ Coverage 68.98% 69.05% +0.07%
==========================================
Files 1906 1906
Lines 74114 74114
Branches 8155 8155
==========================================
+ Hits 51124 51182 +58
+ Misses 20871 20813 -58
Partials 2119 2119
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 11 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
2b20982
to
c641a73
Compare
@@ -35,7 +35,7 @@ def test_create_ssh_tunnel(): | |||
"password": "bar", | |||
} | |||
|
|||
result = SSHTunnelDAO.create(properties) | |||
result = SSHTunnelDAO.create(properties, commit=False) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hughhhh I set commit=False
to mimic the other tests in the ssh_tunnel/commands
folder which use CreateSSHTunnelCommand
that has commit=False
by default. If we enable the commit in this test or in the command ones, they will fail because there's no database with id = 1
. If an actual commit is required for the tests, I suggest opening a follow-up PR and fixing not only this test but the ones in the commands
folder.
SUMMARY
Fix a bug introduced by #24488 that happens when running on SQL Lite. There was an event being registered inside another event and causing a
deque mutated during iteration error
. According to SQL Alchemy docs:BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION